Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generators from params #115

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Remove generators from params #115

merged 1 commit into from
Oct 5, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Oct 5, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

Instances of generators creates before create Gii instance (see config di.php). But generators contain dependencies, which may not exist in app. It's leads to errors.

For example, ActiveRecord\Generator require ConnectionInterface, but demo app don't use Yii DB.

@vjik vjik requested a review from a team October 5, 2023 12:40
@vjik vjik added the status:code review The pull request needs review. label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d0be050) 39.72% compared to head (76e2982) 39.72%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #115   +/-   ##
=========================================
  Coverage     39.72%   39.72%           
  Complexity      224      224           
=========================================
  Files            33       33           
  Lines           871      871           
=========================================
  Hits            346      346           
  Misses          525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@what-the-diff
Copy link

what-the-diff bot commented Oct 5, 2023

PR Summary

  • Removal of Unused Dependencies
    The config/params.php file was tweaked, removing an unnecessary reference (the use statement) to the Yiisoft\Yii\Gii\Generator. This is integral as it could help enhance code maintainability by reducing clutter.
  • Configuration Adjustment
    The generators array under the 'yiisoft/yii-gii' section has been cleared. This simplification makes the code more straightforward and could contribute to easier future adjustments.

@vjik vjik merged commit e10310c into master Oct 5, 2023
12 of 18 checks passed
@vjik vjik deleted the fix-params branch October 5, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants