Enh #204 #205
Open
Enh #204 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds 3 new header keys to $headerCollection. 1. 'http-status-line': The full status line (ie. 'HTTP/1.1 200 OK') 2. 'http-version': The http version returned from the server (ie. 'HTTP/1.1') 3.'http-status-code-reason-phrase': The status line without the HTTP version (ie. '200 OK')
samdark
reviewed
May 17, 2020
| @@ -85,6 +85,9 @@ public function getHeaders() | |||
| if (strpos($rawHeader, 'HTTP/') === 0) { | |||
| $parts = explode(' ', $rawHeader, 3); | |||
| $headerCollection->add('http-code', $parts[1]); | |||
| $headerCollection->add('http-status-line',$rawHeader); | |||
There was a problem hiding this comment.
Formatting should be fixed here (spaces after ,).
|
Thank you for putting effort in the improvement of the Yii framework. In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests. Could you add these please? Thanks! P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests This is an automated comment, triggered by adding the label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 3 new header keys to $headerCollection.