Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for PHP 8.1 #239

Merged
merged 6 commits into from
Jul 18, 2023
Merged

Support for PHP 8.1 #239

merged 6 commits into from
Jul 18, 2023

Conversation

rhertogh
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Jul 12, 2023

PR Summary

  • Updated Build Configuration
    The build process now includes the latest version of PHP (8.1), making our code more compatible with the newest technologies.

  • Improved URL Formatting in CurlFormatter.php and UrlEncodedFormatter.php
    A new safety check has been added in both CurlFormatter.php and UrlEncodedFormatter.phpfiles. Now, they won't add unnecessary symbols to the URL when the URL is empty. This leads to cleaner and more secure URLs.

@rhertogh rhertogh marked this pull request as ready for review July 12, 2023 17:42
@rhertogh rhertogh requested a review from samdark July 12, 2023 17:42
rob006
rob006 reviewed Jul 12, 2023
View reviewed changes
src/CurlFormatter.php Outdated Show resolved Hide resolved
src/UrlEncodedFormatter.php Outdated Show resolved Hide resolved
@rhertogh
Copy link
Contributor Author

@rob006 @samdark
The Request::getFullUrl() now always returns a string (an exception will be thrown in case of an invalid call/config).
https://github.com/yiisoft/yii2-httpclient/pull/239/files#diff-74d71c4d1f9d84b9b0d946ca96eb875274f95d60611611d84cc01cdf6ed04021R341-R343
The tests are updated accordingly.

@samdark samdark added this to the 2.0.16 milestone Jul 18, 2023
@samdark samdark merged commit 2217ea0 into yiisoft:master Jul 18, 2023
10 checks passed
@samdark
Copy link
Member

samdark commented Jul 18, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@rob006 rob006 rob006 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.16
Development

Successfully merging this pull request may close these issues.
3 participants
@rhertogh @samdark @rob006