Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove magic synchronization for relations (issue #19788). #19918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PowerGamer1
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️
Fixed issues #19788

@what-the-diff
Copy link

what-the-diff bot commented Jul 27, 2023

PR Summary

  • Removal of Non-Functional Synchronization Attempts
    The system will no longer make non-functional attempts to automatically synchronize ActiveRecord relations with corresponding foreign key values. This change affects framework/CHANGELOG.md and framework/UPGRADE.md.

  • GridView Improvements
    There's an improvement on GridView; it no longer calls Model::generateAttributeLabel() unnecessarily to generate label values that are not being used. This change is denoted in framework/CHANGELOG.md.

  • FileTarget Log Update
    The logging process for yii\log\FileTarget has been amended, and it will no longer export empty messages - as detailed in framework/CHANGELOG.md.

  • Database Query Caching
    Issues surrounding the caching of a MSSQL query with BLOB data type has been fixed in framework/CHANGELOG.md.

  • Removal of Unnecessary Database Calls
    In framework/db/BaseActiveRecord.php, redundant calls to $this->resetDependentRelations() and $this->setRelationDependencies() have been removed.

  • New Column Addition
    A new column profile_id has been included in tests/data/ar/Customer.php.

  • Removal of Superfluous Tables and Views
    Unnecessary tables and views in all files located at tests/data/ have been removed.

  • Manual Unsetting of Relations
    A note has been added in framework/UPGRADE.md about the requirement to manually unset relations before using them if they are anticipated to change.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (c8c0ea9) 48.89% compared to head (bfe2ef9) 48.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19918      +/-   ##
==========================================
- Coverage   48.89%   48.85%   -0.04%     
==========================================
  Files         445      445              
  Lines       42786    42754      -32     
==========================================
- Hits        20919    20887      -32     
  Misses      21867    21867              
Files Changed Coverage Δ
framework/db/BaseActiveRecord.php 72.40% <ø> (-1.67%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant