Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 trim(): Passing null to parameter #1 ($string) of type string is deprecated #19949

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

uaoleg
Copy link
Contributor

@uaoleg uaoleg commented Sep 11, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 11, 2023

PR Summary

  • Enhancement of groupBy() Method
    The grouping functionality in our database queries has been made more flexible. Now, it can be used without explicitly mentioning which columns the data should be grouped by. This makes usage more convenient in scenarios where specific column-based grouping is not needed.

@rob006
Copy link
Contributor

rob006 commented Sep 12, 2023

Why would you pass null to groupBy()?

@uaoleg
Copy link
Contributor Author

uaoleg commented Sep 12, 2023

Why would you pass null to groupBy()?

To clear GROUP BY

@terabytesoftw
Copy link
Member

Please update branch,

Thks.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -37.07% ⚠️

Comparison is base (2995696) 48.95% compared to head (7a260f7) 11.89%.

❗ Current head 7a260f7 differs from pull request most recent head fd5c1bb. Consider uploading reports for the commit fd5c1bb to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19949       +/-   ##
===========================================
- Coverage   48.95%   11.89%   -37.07%     
===========================================
  Files         445      445               
  Lines       42811    42262      -549     
===========================================
- Hits        20957     5025    -15932     
- Misses      21854    37237    +15383     
Files Changed Coverage Δ
framework/db/Query.php 94.17% <100.00%> (-0.31%) ⬇️

... and 289 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uaoleg
Copy link
Contributor Author

uaoleg commented Sep 19, 2023

@terabytesoftw done

@bizley
Copy link
Member

bizley commented Sep 20, 2023

Please add a changelog, thanks.

@uaoleg
Copy link
Contributor Author

uaoleg commented Sep 20, 2023

@bizley done

@bizley bizley merged commit 7ae255c into yiisoft:master Sep 20, 2023
36 of 48 checks passed
@bizley
Copy link
Member

bizley commented Sep 20, 2023

Cheers

@bizley bizley added this to the 2.0.50 milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants