Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes in mimeTypes.php from 4a1f2c6b9bc90427e91da73f5e8c8fa33d3c53c1 #19992

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

rob006
Copy link
Contributor

@rob006 rob006 commented Oct 6, 2023

see 4a1f2c6#r129302787

restores #19936

@what-the-diff
Copy link

what-the-diff bot commented Oct 6, 2023

PR Summary

  • Improved PHP Version Check for MIME Types
    This update includes a bug fix to better handle MIME types depending on the PHP version being used. This will ensure we are using the correct MIME type definitions where needed.

  • Updated MIME Types Definition in libmagic
    We've fixed a bug related to the 'libmagic' library, a crucial part of our system which helps detect file types correctly. This was done by including a new type, specifically 'xz' files, and treating them as 'application/octet-stream'. This change expands the variety of file types our system can correctly identify and handle.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (290e03c) 20.07% compared to head (9f51fe3) 48.94%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19992       +/-   ##
===========================================
+ Coverage   20.07%   48.94%   +28.86%     
===========================================
  Files         445      445               
  Lines       42592    42817      +225     
===========================================
+ Hits         8552    20956    +12404     
+ Misses      34040    21861    -12179     
Files Coverage Δ
framework/helpers/mimeTypes.php 0.30% <100.00%> (+0.30%) ⬆️

... and 245 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schmunk42
Copy link
Contributor

Was this the only version check which was accidentally changed?

Since there were 3 checks in the original PR: https://github.com/yiisoft/yii2/pull/19936/files

@rob006
Copy link
Contributor Author

rob006 commented Oct 6, 2023

For FileValidatorTest it is still there:
https://github.com/yiisoft/yii2/blob/master/tests/framework/validators/FileValidatorTest.php#L550

MimeTest was removed in #19951

@bizley bizley merged commit 53f1619 into yiisoft:master Oct 6, 2023
50 checks passed
@rob006 rob006 deleted the mimeTypes-revert branch October 6, 2023 12:58
@bizley bizley mentioned this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants