Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix #20055 causes bad result for pagination using for example gridview #20176

Merged
merged 10 commits into from
Jun 8, 2024
Merged

Bug fix #20055 causes bad result for pagination using for example gridview #20176

merged 10 commits into from
Jun 8, 2024

Conversation

lav45
Copy link
Contributor

@lav45 lav45 commented Jun 1, 2024

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ✔️
Fixed issues #20175

lav45 added 3 commits June 1, 2024 12:55
@lav45
Fix yiisoft#20175 Made the BaseDataProvider::prepareTotalCount() meth…
bcc499b 
…od executable. Add internal cache for ActiveDataProvider and SqlDataProvider.
@lav45
clear code
a6e4e0b
@lav45
Fix Where $this->db is null
834e151
@samdark samdark added this to the 2.0.50.1 milestone Jun 1, 2024
@samdark
Copy link
Member

samdark commented Jun 1, 2024

@procin would you please test it?

@codecov Codecov
Copy link

codecov bot commented Jun 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.99%. Comparing base (e1268d1) to head (bab305e).
Report is 13 commits behind head on master.

❗ Current head bab305e differs from pull request most recent head 149f6a1

Please upload reports for the commit 149f6a1 to get more accurate results.

Additional details and impacted files 
@@              Coverage Diff              @@
##             master   #20176       +/-   ##
=============================================
+ Coverage     22.16%   64.99%   +42.82%     
- Complexity    11386    11391        +5     
=============================================
  Files           430      430               
  Lines         37113    36919      -194     
=============================================
+ Hits           8225    23994    +15769     
+ Misses        28888    12925    -15963

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lav45 lav45 mentioned this pull request Jun 1, 2024
Closed
@bizley bizley mentioned this pull request Jun 2, 2024
Closed
@samdark
Copy link
Member

samdark commented Jun 3, 2024

@nadar would you please check if this PR fixes the issues you have?

@samdark
Copy link
Member

samdark commented Jun 3, 2024

Thanks. A line for the CHANGELOG is needed.

@terabytesoftw terabytesoftw mentioned this pull request Jun 5, 2024
Closed
samdark
samdark reviewed Jun 5, 2024
View reviewed changes
framework/data/Pagination.php Outdated Show resolved Hide resolved
framework/data/ActiveDataProvider.php Outdated Show resolved Hide resolved
framework/data/Pagination.php Show resolved Hide resolved
@samdark samdark merged commit 3fa2d61 into yiisoft:master Jun 8, 2024
5 of 7 checks passed
@marcovtwout marcovtwout mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.51
Development

Successfully merging this pull request may close these issues.
2 participants
@lav45 @samdark