Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doing an environment file #27

Open
yjmantilla opened this issue Jul 17, 2021 · 5 comments
Open

Doing an environment file #27

yjmantilla opened this issue Jul 17, 2021 · 5 comments
Assignees

Comments

@yjmantilla
Copy link
Owner

@DavidjWhite33 commented that:

One thing I wonder relating to the note you make below about installing ‘on a clean environment’ – I wonder if a simple pathway to help with development and subsequent expansion to more users would be to follow the mne-python approach of installing via a conda environment?

I agree with this. I think one of the issues with python packages is that they can break because of the dependencies' updates. In that sense I think having an environment or requirements file that also says the last version of the dependencies the package worked with would be useful.

@yjmantilla yjmantilla self-assigned this Jul 17, 2021
@civier
Copy link
Collaborator

civier commented Jul 27, 2021 via email

@stebo85
Copy link
Collaborator

stebo85 commented Jul 27, 2021

I would not make this dependent on VNM - it should be a standard conda or pip environment that can be reproduced in any python setup. There is no standard conda environment in VNM and will not exist any time soon.

@DavidjWhite33
Copy link
Collaborator

@civier I have not done any sovabids testing using VNM. If a sovabids conda env is set up, I am happy to give a go on VNM (and elsewhere).

@yjmantilla
Copy link
Owner Author

yjmantilla commented Jul 27, 2021

@civier

Are both of you work on VNM?

At the start of the development I did it with the VNM, nevertheless I was more comfortable with the development with my windows desktop. I figured the package should work in the VNM since the test of the CI worked.

I would not make this dependent on VNM - it should be a standard conda or pip environment that can be reproduced in any python setup.

I agree with this

The main reason I have not done the environment file yet is because I dont want set the environment manually, requiring me to update it everytime I change something. I mainly want to have some process that saves the last environment sovabids was known to work so that if some package breaks some functionality, the user can install that environment that had the working versions of the packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants