Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small GUI issues #40

Open
2 of 3 tasks
civier opened this issue Aug 20, 2021 · 7 comments
Open
2 of 3 tasks

Small GUI issues #40

civier opened this issue Aug 20, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@civier
Copy link
Collaborator

civier commented Aug 20, 2021

I tested the GUI. It works really well. Congratulations!

Some small things that can be improved:

  • When editing the mapping files, it should say "Modifying individual participant mapping file:" rather than "Modifying rules file:".
  • Downloaded zip file doesn't have a .zip extension (no extension at all)
  • Files within downloaded zip file have the path home/neuro/sovabids/front/app/_convert/* when sovabids is installed in /home/neuro/sovabids, so I guess only the initial slash is removed from the paths (when in reality, home/neuro/sovabids/front/app/_convert/ should have been removed). Maybe because I'm running it on Linux rather than Windows?
@civier civier added the bug Something isn't working label Aug 20, 2021
@yjmantilla yjmantilla self-assigned this Aug 21, 2021
@yjmantilla
Copy link
Owner

@civier
Regarding the second point Im not sure what is happening, I just tested the GUI and at the download it shows:

image

That is, it has the .zip extension. Is this an linux-only issue?

@yjmantilla
Copy link
Owner

For the download we use:

    response = Response(s.getvalue(), content_type = "application/x-zip-compressed")

So is possible that some browsers identify the content type and add the .zip by themselves. The filename is missing too so I guess that my browser just names it as 'downloads'.

I will inquiry in the matter

@yjmantilla
Copy link
Owner

@civier in the last version of the front I think I fixed the filename issue, let me know if it is resolved on your end

@yjmantilla
Copy link
Owner

Files within downloaded zip file have the path home/neuro/sovabids/front/app/_convert/* when sovabids is installed in /home/neuro/sovabids, so I guess only the initial slash is removed from the paths (when in reality, home/neuro/sovabids/front/app/_convert/ should have been removed). Maybe because I'm running it on Linux rather than Windows?

@civier
Could you provide a snapshot of where and/or how are you seeing this. Im not sure what is the problem. Is it mainly an aesthetic issue regarding not having the '/' at the start in linux or does this affects the zip file? Are you able to decompress it ?

@yjmantilla
Copy link
Owner

For the first issue of renaming the mapping annotation, here is what will currently look like:

image

@civier
Copy link
Collaborator Author

civier commented Aug 21, 2021 via email

@yjmantilla
Copy link
Owner

Ahh I understand the issue now. In windows this doesn't happen or at least when I extract with 7z (i just press the extract here dialog). I will need to dig in this matter then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants