[ASAP-679] - engagement analytics fix #4379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add fields to gp2 output export * linting * return rrid and accession number * fix test --------- Co-authored-by: Gabriela Ueno <[email protected]>
…rt and fix typo in news filter (#4378) * add short description and first version data to research outputs export and fix typo in news filter * fix typecheck * update query to return rrid and accession and fix lint * add test to cover undefined fields * update CRN schema * update data provider
…m/yldio/asap-hub into ASAP-679-engagement-analytics-fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4379 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 1050 1050
Lines 20099 20126 +27
Branches 6315 6331 +16
=======================================
+ Hits 19990 20017 +27
Misses 109 109 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://asaphub.atlassian.net/browse/ASAP-679
Total Speakerscolumn was because there are Event Speakers linked to the teams that do not have events attached.To fix that I only count speakers when there is an event attached.