-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASAP-679] - update engagement calculation & tests #4380
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4380 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 1050 1050
Lines 20119 20126 +7
Branches 6327 6331 +4
=======================================
+ Hits 20010 20017 +7
Misses 109 109 ☔ View full report in Codecov by Sentry. |
dianaguimaraes
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://asaphub.atlassian.net/browse/ASAP-679
Total Speakers
column was because there are Event Speakers linked to the teams that do not have events attached.To fix that I only count speakers when there is an event attached.
Events
column previously counted both Past & Upcoming Events. It should count only events in the Past Event column https://asaphub.atlassian.net/browse/ASAP-679?focusedCommentId=11807Current results computed for Prod can be found in this sheet https://docs.google.com/spreadsheets/d/1iGTVBmsXe58qWwS6_zPlIAWEKwZ9mw2v9kfM4S8ijV4/edit?usp=sharing