Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASAP-679] - update engagement calculation & tests #4380

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

AkosuaA
Copy link
Collaborator

@AkosuaA AkosuaA commented Sep 17, 2024

ref: https://asaphub.atlassian.net/browse/ASAP-679

  • Filtered out cancelled events
  • The inflated numbers in the Total Speakers column was because there are Event Speakers linked to the teams that do not have events attached.
Screenshot 2024-09-16 at 13 54 30 Screenshot 2024-09-16 at 14 08 33 Screenshot 2024-09-16 at 14 10 32

To fix that I only count speakers when there is an event attached.

Current results computed for Prod can be found in this sheet https://docs.google.com/spreadsheets/d/1iGTVBmsXe58qWwS6_zPlIAWEKwZ9mw2v9kfM4S8ijV4/edit?usp=sharing

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (d5e5665) to head (c37e7e4).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4380   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files        1050     1050           
  Lines       20119    20126    +7     
  Branches     6327     6331    +4     
=======================================
+ Hits        20010    20017    +7     
  Misses        109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AkosuaA AkosuaA merged commit 7b5a922 into master Sep 18, 2024
63 checks passed
@AkosuaA AkosuaA deleted the ASAP-679-engagement-analytics-update branch September 18, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants