Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

request all (if more than 1000) blog posts from Contentful #425

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

jeysal
Copy link
Contributor

@jeysal jeysal commented Nov 13, 2019

request all (if more than 1000) blog posts from Contentful - Trello ticket

@jeysal jeysal requested a review from omonk November 13, 2019 17:44
@jeysal jeysal force-pushed the blog-limit-1000 branch 2 times, most recently from 6cb85f0 to 7a3d444 Compare November 13, 2019 19:09
@jeysal jeysal closed this Nov 13, 2019
@jeysal
Copy link
Contributor Author

jeysal commented Nov 13, 2019

result: []

@jeysal
Copy link
Contributor Author

jeysal commented Nov 13, 2019

Cause for the difference in transpilation causing errors during module loading: netlify/netlify-lambda#200
Changed it back to .babelrc for now

@omonk
Copy link
Contributor

omonk commented Nov 14, 2019

I think this is default webpack behaviour no? https://github.com/netlify/netlify-lambda#webpack-configuration
I actually contributed to the netlify-lambda package to update the cli options to add a flag to not use the root babelrc file. Previously it was breaking because the babelrc in the project uses babel-preset-gatsby which throws errors when used when compiling the lamdbas.

yld.io/package.json

Lines 103 to 104 in 52bb908

"build:lambda": "netlify-lambda -c webpack.functions.js --babelrc false build src/functions",
"start:lambda": "netlify-lambda -c webpack.functions.js --babelrc false serve src/functions",

PR: netlify/netlify-lambda#154

@jeysal
Copy link
Contributor Author

jeysal commented Nov 14, 2019

Yeah I noticed the --babelrc false as well but I don't think it is working? At least the behavior changed when I renamed from .babelrc.js to .babelrc so ...

@omonk
Copy link
Contributor

omonk commented Nov 14, 2019

Ah right yeah, its not picking up the .babelrc.js as you mentioned... we could probably make a PR to the package to update include .babelrc.js as well

@omonk omonk merged commit 6a0bf8a into master Nov 14, 2019
@sergioramos sergioramos deleted the blog-limit-1000 branch August 13, 2020 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants