Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add glimmer support #85

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Conversation

IgnaceMaes
Copy link
Contributor

@IgnaceMaes IgnaceMaes commented Oct 22, 2023

Adds support for .gjs and .gts file formats. Glimmer <template> tag components are the new format which power Ember.js. References:

RFC: https://rfcs.emberjs.com/id/0779-first-class-component-templates
Component implementation: https://github.com/ember-template-imports/ember-template-imports

Ember diagnostics provided by Glint are also added as an input.

Local test

Before:

Screenshot 2023-10-23 at 19 22 54

After:

Screenshot 2023-10-23 at 19 22 44

@NullVoxPopuli
Copy link

This is very exciting!!!!

@IgnaceMaes
Copy link
Contributor Author

@yoavbls I hate to ping, but any chance this could be looked at when you find some time?

I've been using a locally compiled version of the plugin for over two months already and it's been working great. Having this in the official plugin would be greatly beneficial to all Ember.js community members.

@yoavbls
Copy link
Owner

yoavbls commented Jan 5, 2024

I'm sorry, I wasn't available because of the situation in Israel.
It looks great. Thank you for this contribution 😀
I hope I'll publish a new version today or tomorrow.

@yoavbls yoavbls merged commit dd8e522 into yoavbls:main Jan 5, 2024
@IgnaceMaes
Copy link
Contributor Author

Thank you for creating this amazing extension.

Take care!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants