-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syringe guns now embed syringes #14192
Conversation
commit 8ec2fca Author: nmajask <[email protected]> Date: Thu May 19 15:26:09 2022 -0400 Converts embedding into a proc also adds a embed tic proc that is called whenever the embedde has a life tick
Syringe gun now embeds syringes and slowly transfers the reagents
pretty sure syringes take glass to make, so maybe it should have a chance to shatter if it hits a wall or something? |
Do they drop after they empty of juice or they still will be embedded ? |
Seconding this. |
If I do that, I'll do it in a separate PR as this will mess with balance enough for one PR. |
They don't, but syringe embeds do almost nothing. |
Does it work on xenos??? |
/obj/item/ammo_casing/shotgun/dart/noreact/Initialize() | ||
. = ..() | ||
ENABLE_BITFIELD(reagents.flags, NO_REACT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could just remove the initialize here if you're gonna remove the bitflag
Cool idea, I wonder how this would effect the blowdarts |
So this should prevent instant death mixes, like black powder with napalm, or water+ potassium, right? |
No, it doesn't as carbons can't get embedded with stuff, maybe I'll add that with my other PR. |
Yes, though it will inject it every life tick, so there may be a lot of tiny explosions. |
you might want to make it so 15u of mutation toxin doesn't perma stun someone because it is ingested every second |
commit c6d04d4 Author: nmajask <[email protected]> Date: Sat May 21 16:12:51 2022 -0400 b commit da83fdc Author: nmajask <[email protected]> Date: Sat May 21 15:47:52 2022 -0400 a commit 8ec2fca Author: nmajask <[email protected]> Date: Thu May 19 15:26:09 2022 -0400 Converts embedding into a proc also adds a embed tic proc that is called whenever the embedde has a life tick
with the funny thing livers do where they instantly purge anything less than 3u of a toxin this makes all unfriendly syringe guns completely useless because unless you're using a bluespace syringe it only transfers 1u at a time |
Would make more sense if it injected half it's amount instantly and gradually releases the rest, since the momentum of the shot would instantly inject some of the contents |
Document the changes in your pull request
Requires #14183
Reworks syringe guns to embed the syringe and slowly transfer reagents at a rate of 0.2 * the normal transfer amount and also drop the syringe if it misses. Syringes now also should embed normally and have the same effect. I will need to fix other carbons not being effected.
Wiki Documentation
If the syringe gun is mentioned, maybe include this.
Changelog
🆑
tweak: Syringes can now embed, causing them to slowly transfer reagents.
tweak: Syringe guns now embed syringes, and drop the syringe when missed.
/:cl: