Minor rework to how toxic chemicals work #22504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code/modules/surgery/organs/liver.dm
Outdated
| toxpwr += T.toxpwr | ||
| provide_pain_message = provide_pain_message || !T.silent_toxin | ||
|
|
||
| sort_list(toxpwr, cmp = /proc/cmp_numeric_dsc) //sort all toxpowers scaling from highest to lowest |
There was a problem hiding this comment.
I feel like this should probably be cached on the liver and updated whenever a toxin is added or removed from the body so you don't have to sort the list every single tick.
There was a problem hiding this comment.
guh, i considered that but it sounds like a lot of work
|
i really should implement sarah's suggestion, but i don't have the motivation, and haven't for a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toxic chemicals now work by
Put the toxpower of every chemical in a list in descending order
first chemical (highest) does full damage
second chemical does 50% reduced damage
third chemical does 75% reduced damage
fourth chemical does 87.5% reduced damage
and so forth and so on
Why is this good for the game?
i hate the arbitrary purge threshold, it makes certain toxins that are designed to be potent in small amounts utterly useless, as they get instantly purged when low
Changing it to this allows for something like cyanide to actually be good in small doses
while still preventing loading a syringe with 1u of 30 different toxins to instantly kill someone
Gave polys a toxmod to account for their livers being nerfed a bit
Testing
🆑
tweak: Polysmorph now have a 0.8 toxmod
tweak: Livers no longer instantly purge toxic chemicals when below an arbitrary number
tweak: Toxic chemicals now deal half damage for every stronger toxin in the bloodstream
tweak: Toxic chemicals now no longer scale liver damage with volume
/:cl: