Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:未ログイン時にインスタンス画面が正常に表示されない #113

Merged
merged 6 commits into from
Jun 23, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Jun 23, 2024

What

image

Why

image

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

kozakura913 and others added 6 commits June 23, 2024 02:36
# Conflicts:
#	.github/ISSUE_TEMPLATE/01_bug-report.yml
#	.github/ISSUE_TEMPLATE/02_feature-request.yml
#	.github/workflows/release-edit-with-push.yml
#	.github/workflows/release-with-dispatch.yml
#	.github/workflows/release-with-ready.yml
#	README.md
#	locales/ar-SA.yml
#	locales/ca-ES.yml
#	locales/cs-CZ.yml
#	locales/de-DE.yml
#	locales/en-US.yml
#	locales/es-ES.yml
#	locales/fr-FR.yml
#	locales/id-ID.yml
#	locales/it-IT.yml
#	locales/ja-KS.yml
#	locales/ko-GS.yml
#	locales/ko-KR.yml
#	locales/no-NO.yml
#	locales/pt-PT.yml
#	locales/ru-RU.yml
#	locales/th-TH.yml
#	locales/vi-VN.yml
#	locales/zh-CN.yml
#	locales/zh-TW.yml
#	package.json
#	packages/backend/package.json
#	packages/backend/src/core/CoreModule.ts
#	packages/backend/src/core/RoleService.ts
#	packages/backend/src/core/UserFollowingService.ts
#	packages/backend/src/core/activitypub/ApInboxService.ts
#	packages/backend/src/core/entities/DriveFileEntityService.ts
#	packages/backend/src/core/entities/NoteReactionEntityService.ts
#	packages/backend/src/core/entities/UserEntityService.ts
#	packages/backend/src/misc/json-schema.ts
#	packages/backend/src/models/Role.ts
#	packages/backend/src/models/json-schema/role.ts
#	packages/backend/src/queue/processors/InboxProcessorService.ts
#	packages/backend/src/server/api/endpoints/admin/federation/update-instance.ts
#	packages/backend/src/server/api/endpoints/flash/create.ts
#	packages/backend/src/server/api/stream/channels/home-timeline.ts
#	packages/backend/src/server/web/ClientServerService.ts
#	packages/backend/test/e2e/antennas.ts
#	packages/backend/test/unit/RoleService.ts
#	packages/cherrypick-js/etc/cherrypick-js.api.md
#	packages/cherrypick-js/package.json
#	packages/cherrypick-js/src/autogen/models.ts
#	packages/cherrypick-js/src/autogen/types.ts
#	packages/frontend/.storybook/generate.tsx
#	packages/frontend/package.json
#	packages/frontend/src/components/MkFormDialog.vue
#	packages/frontend/src/components/MkNotification.vue
#	packages/frontend/src/components/MkReactionsViewer.reaction.vue
#	packages/frontend/src/components/global/MkA.vue
#	packages/frontend/src/os.ts
#	packages/frontend/src/pages/about-misskey.vue
#	packages/frontend/src/pages/admin/RolesEditorFormula.vue
#	packages/frontend/src/pages/admin/modlog.ModLog.vue
#	packages/frontend/src/pages/page.vue
#	packages/frontend/src/pages/timeline.vue
#	packages/frontend/src/scripts/form.ts
#	packages/frontend/vite.config.local-dev.ts
#	packages/sw/package.json
#	pnpm-lock.yaml
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (5f3f0f1) to head (9988557).

Files Patch % Lines
packages/frontend/src/instance.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #113       +/-   ##
============================================
+ Coverage    66.11%   77.87%   +11.76%     
============================================
  Files         1074      193      -881     
  Lines       131808    29083   -102725     
  Branches      4957      471     -4486     
============================================
- Hits         87141    22649    -64492     
+ Misses       44634     6428    -38206     
+ Partials        33        6       -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net penginn-net merged commit 92f3032 into yojo-art:develop Jun 23, 2024
13 of 17 checks passed
@penginn-net penginn-net deleted the fix-instancetop branch July 20, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants