Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unset-user-mutual-linkにsecureを追加 #340

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

kozakura913
Copy link
Collaborator

#111

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link
Contributor

github-actions bot commented Aug 16, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -6015,7 +6015,7 @@
       "post": {
         "operationId": "admin___unset-user-mutual-link",
         "summary": "admin/unset-user-mutual-link",
-        "description": "No description provided.\n\n**Credential required**: *Yes* / **Permission**: *write:admin:unset-user-mutual-link*",
+        "description": "No description provided.\n\n**Internal Endpoint**: This endpoint is an API for the cherrypick mainframe and is not intended for use by third parties.\n**Credential required**: *Yes* / **Permission**: *write:admin:unset-user-mutual-link*",
         "externalDocs": {
           "description": "Source code",
           "url": "https://github.com/kokonect-link/cherrypick/blob/develop/packages/backend/src/server/api/endpoints/admin/unset-user-mutual-link.ts"

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.52%. Comparing base (dcd2af6) to head (7e90129).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #340      +/-   ##
===========================================
+ Coverage    38.76%   40.52%   +1.75%     
===========================================
  Files         1655     1659       +4     
  Lines       215913   222341    +6428     
  Branches      3679     3802     +123     
===========================================
+ Hits         83704    90107    +6403     
+ Misses      131600   131586      -14     
- Partials       609      648      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Aug 16, 2024

@kozakura913 kozakura913 marked this pull request as ready for review August 16, 2024 00:44
@kozakura913 kozakura913 merged commit 5266418 into yojo-art:develop Aug 16, 2024
28 of 31 checks passed
@kozakura913 kozakura913 deleted the fix_unset_mutual_link branch August 16, 2024 06:09
@kozakura913 kozakura913 added this to the yojo0.6.0 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants