Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Outboxから投稿を所得する際にタイムラインに投稿が流れないように #348

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Aug 19, 2024

What

Why

outbox取得するとTLが荒れる、手動照会の挙動に近づける

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link
Contributor

github-actions bot commented Aug 19, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 38.82%. Comparing base (bf0577c) to head (ab83e4b).
Report is 2 commits behind head on develop.

Files Patch % Lines
...rc/core/activitypub/models/ApOutboxFetchService.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #348      +/-   ##
===========================================
+ Coverage    38.77%   38.82%   +0.05%     
===========================================
  Files         1655     1655              
  Lines       215932   215935       +3     
  Branches      2842     3753     +911     
===========================================
+ Hits         83720    83836     +116     
+ Misses      131603   131451     -152     
- Partials       609      648      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 added this to the yojo0.6.0 milestone Aug 20, 2024
@penginn-net penginn-net changed the title outboxから投稿取得するときはサイレントに作るように Fix: Outboxから投稿を所得する際にタイムラインに投稿が流れないように Aug 20, 2024
@penginn-net penginn-net merged commit efe479f into yojo-art:develop Aug 20, 2024
13 of 18 checks passed
@kozakura913 kozakura913 mentioned this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants