Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 翻訳にdeepl以外を利用していると翻訳できない問題を修正 #355

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Aug 20, 2024

What

translatorAvailableが api/metaで正しく取得できない問題を修正

Why

deepl以外を利用しているときにtranslatorAvailableがフロント側に伝わらず、翻訳できなかったため
Resolve #240

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@kozakura913 kozakura913 added this to the yojo0.6.0 milestone Aug 20, 2024
Copy link
Contributor

github-actions bot commented Aug 20, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.76%. Comparing base (dcd2af6) to head (cf3eb67).
Report is 5 commits behind head on develop.

Files Patch % Lines
...ges/backend/src/core/entities/MetaEntityService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #355      +/-   ##
===========================================
- Coverage    38.76%   38.76%   -0.01%     
===========================================
  Files         1655     1655              
  Lines       215913   215932      +19     
  Branches      3679     3680       +1     
===========================================
+ Hits         83704    83709       +5     
+ Misses      131600   131575      -25     
- Partials       609      648      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net penginn-net changed the title Fix:translatorAvailable Fix: 翻訳にdeepl以外を利用していると翻訳できない問題を修正 Aug 20, 2024
@penginn-net penginn-net merged commit bf0577c into yojo-art:develop Aug 20, 2024
24 of 26 checks passed
@penginn-net penginn-net deleted the fix-translator-available branch August 20, 2024 06:41
@kozakura913 kozakura913 mentioned this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

translatorAvailableの値が切り替わらない
2 participants