Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(frontend):お気に入りタグリストを追加 #358

Merged
merged 10 commits into from
Aug 27, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Aug 21, 2024

What

お気に入りタグリストを追加

Why

Resolve #187

Additional info (optional)

タグ管理画面がなんだかなーという感じ

  • タグ画面の見た目改善
  • 追加/削除時にリアルタイム更新

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 214 lines in your changes missing coverage. Please review.

Project coverage is 20.27%. Comparing base (a8da3e9) to head (e35c590).
Report is 2 commits behind head on develop.

Files Patch % Lines
packages/frontend/src/pages/my-tags/index.vue 0.00% 149 Missing and 1 partial ⚠️
packages/frontend/src/pages/timeline.vue 0.00% 46 Missing ⚠️
packages/frontend/src/navbar.ts 0.00% 6 Missing ⚠️
packages/frontend/src/router/definition.ts 0.00% 5 Missing ⚠️
packages/frontend/src/store.ts 0.00% 4 Missing ⚠️
packages/frontend/src/pages/settings/timeline.vue 0.00% 2 Missing ⚠️
...rontend/src/pages/settings/preferences-backups.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #358       +/-   ##
============================================
- Coverage    38.75%   20.27%   -18.48%     
============================================
  Files         1655      783      -872     
  Lines       216033   116596    -99437     
  Branches      3730     1086     -2644     
============================================
- Hits         83722    23644    -60078     
+ Misses      131702    92366    -39336     
+ Partials       609      586       -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net
Copy link
Collaborator Author

vueわがんにゃい

@penginn-net penginn-net marked this pull request as ready for review August 27, 2024 08:19
@penginn-net penginn-net merged commit 0bbd178 into yojo-art:develop Aug 27, 2024
16 of 18 checks passed
@penginn-net penginn-net deleted the resolve-187 branch August 27, 2024 12:49
@kozakura913 kozakura913 mentioned this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

お気に入りタグ
2 participants