Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ユーザーnull(System)の場合forceがfalseでも新規追加されるのを修正 #363

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Aug 21, 2024

What

Fix: ユーザーnull(System)の場合forceがfalseでも新規追加されるのを修正

Why

systemでもforceを見た方が良い

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@penginn-net penginn-net changed the title Fix: ユーザーnull(System)の場合forceのオプションが適用されないのを修正 Fix: ユーザーnull(System)の場合forceがfalseでも新規追加されるのを修正 Aug 21, 2024
@penginn-net
Copy link
Collaborator Author

ファイルが追加される~のがいい?

@penginn-net
Copy link
Collaborator Author

にゃーん

@penginn-net penginn-net removed the request for review from kozakura913 August 22, 2024 11:28
@kozakura913
Copy link
Collaborator

CI落ちてるの気になる

@penginn-net
Copy link
Collaborator Author

checkoutできてない?

@penginn-net
Copy link
Collaborator Author

コンフリクト直すの忘れてた

Copy link
Contributor

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.75%. Comparing base (0453a4e) to head (55f2035).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #363       +/-   ##
============================================
+ Coverage    20.31%   38.75%   +18.44%     
============================================
  Files          782     1655      +873     
  Lines       116377   215978    +99601     
  Branches      1085     3734     +2649     
============================================
+ Hits         23644    83713    +60069     
- Misses       92148   131656    +39508     
- Partials       585      609       +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net penginn-net merged commit c061a17 into yojo-art:develop Aug 22, 2024
24 of 26 checks passed
@penginn-net penginn-net deleted the drive-force-system branch August 22, 2024 11:56
@kozakura913 kozakura913 added this to the yojo0.6.0 milestone Aug 23, 2024
@kozakura913 kozakura913 mentioned this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants