Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

お気に入り登録クリップの一覧画面から登録解除できるように #448

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Sep 16, 2024

What

お気に入り登録クリップの一覧画面から登録解除できるように

Why

お気に入り登録したクリップが削除されると一覧が取得できない問題を修正する

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link
Contributor

github-actions bot commented Sep 16, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음

Get diff files from Workflow Page

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 15.42056% with 181 lines in your changes missing coverage. Please review.

Project coverage is 38.70%. Comparing base (4ae086f) to head (598dde2).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/misc/remote-api-utils.ts 17.05% 107 Missing ⚠️
packages/frontend/src/components/MkClipPreview.vue 0.00% 38 Missing ⚠️
packages/backend/src/core/ClipService.ts 7.40% 25 Missing ⚠️
...end/src/server/api/endpoints/clips/my-favorites.ts 0.00% 7 Missing ⚠️
...backend/src/server/api/endpoints/clips/favorite.ts 0.00% 2 Missing ⚠️
...es/backend/src/server/api/endpoints/users/clips.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #448      +/-   ##
===========================================
- Coverage    39.54%   38.70%   -0.85%     
===========================================
  Files         1665     1662       -3     
  Lines       223798   217452    -6346     
  Branches      2617     2860     +243     
===========================================
- Hits         88512    84162    -4350     
+ Misses      134677   132681    -1996     
  Partials       609      609              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 self-assigned this Sep 16, 2024
@kozakura913 kozakura913 added this to the yojo1.1.0 milestone Sep 16, 2024
@kozakura913 kozakura913 merged commit de66bbf into yojo-art:develop Sep 17, 2024
25 of 26 checks passed
@kozakura913 kozakura913 deleted the remote_clip_favorites branch September 17, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants