Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: リアクション検索 #489

Draft
wants to merge 39 commits into
base: develop
Choose a base branch
from

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Sep 30, 2024

What

ノートにつけられたリアクションを利用した検索ができるように

Why

Resolve #213
Close #214

Additional info (optional)

ベースブランチが #449 だからマージ後に開ける

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

penginn-net and others added 30 commits September 14, 2024 13:52
* a

* a

* a

* a

* 204

* 200

* 分離

* ファイルオプション

* a

* add

* a

* こっち

* add

* a

* Revert "a"

This reverts commit db285e8.

* a

* a

* a

* a

* a

* f

* a

* a

* a

* q

* a

* a

* a

* a

* a

* a

* a

* a

* Update test-backend.yml

* a

* a

* a

* Revert "Update test-backend.yml"

This reverts commit d4bdb52.

* a

* a
* OpenSearch有効な状態でテスト回してみる

* CI見る

* fix

* リネーム

* aidx

* ci

* DISABLE_SECURITY_PLUGIN

* https://github.com/marketplace/actions/run-opensearch
* a

* a

* a

* a

* a

* a

* a

* a

* a

* a

* fix
* a

* fix

* fix

* a

* a

* a

* a

* a

* a

* a

* visibility

* ブロック/ミュート

* あ

* a

* a

* a

* a

* Revert "visibility"

This reverts commit 3ed682b.

* Reapply "visibility"

This reverts commit 1709831.

* a

* a

* a

* fix

* a

* fix:logger

* fix

* a
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 26.01279% with 694 lines in your changes missing coverage. Please review.

Project coverage is 62.36%. Comparing base (67e077c) to head (1d078b1).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/AdvancedSearchService.ts 23.91% 576 Missing ⚠️
packages/backend/src/core/QueryService.ts 6.52% 43 Missing ⚠️
...ckend/src/server/api/endpoints/admin/full-index.ts 26.92% 19 Missing ⚠️
packages/backend/src/core/ClipService.ts 13.33% 13 Missing ⚠️
.../src/server/api/endpoints/notes/advanced-search.ts 63.88% 13 Missing ⚠️
packages/backend/src/core/ReactionService.ts 20.00% 8 Missing ⚠️
...src/server/api/endpoints/notes/favorites/create.ts 11.11% 8 Missing ⚠️
...ckend/src/server/api/endpoints/notes/polls/vote.ts 12.50% 7 Missing ⚠️
...src/server/api/endpoints/notes/favorites/delete.ts 33.33% 2 Missing ⚠️
packages/backend/src/core/DeleteAccountService.ts 66.66% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #489       +/-   ##
============================================
+ Coverage    40.40%   62.36%   +21.95%     
============================================
  Files         1668      881      -787     
  Lines       224536   107888   -116648     
  Branches      2673     1691      -982     
============================================
- Hits         90721    67281    -23440     
+ Misses      133206    40586    -92620     
+ Partials       609       21      -588     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Thank you for sending us a great Pull Request! 👍
Please regenerate cherrypick-js type definitions! 🙏

example:

pnpm run build-cherrypick-js-with-types

Copy link
Contributor

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -13122,6 +13122,31 @@
             "bearerAuth": []
           }
         ],
+        "requestBody": {
+          "required": true,
+          "content": {
+            "application/json": {
+              "schema": {
+                "type": "object",
+                "properties": {
+                  "index": {
+                    "type": "string",
+                    "enum": [
+                      "notes",
+                      "reaction",
+                      "pollVote",
+                      "clipNotes",
+                      "Favorites"
+                    ]
+                  }
+                },
+                "required": [
+                  "index"
+                ]
+              }
+            }
+          }
+        },
         "responses": {
           "204": {
             "description": "OK (without any results)"
@@ -50014,6 +50039,9 @@
                   "isExplorable": {
                     "type": "boolean"
                   },
+                  "isIndexable": {
+                    "type": "boolean"
+                  },
                   "hideOnlineStatus": {
                     "type": "boolean"
                   },
@@ -61760,6 +61788,26 @@
                     "type": "string",
                     "description": "指定した文字列を含むノートを返します"
                   },
+                  "reactions": {
+                    "type": "array",
+                    "description": "指定したリアクションがつけられたノートを探します",
+                    "uniqueItems": true,
+                    "minItems": 1,
+                    "maxItems": 16,
+                    "items": {
+                      "type": "string"
+                    }
+                  },
+                  "reactionsExclude": {
+                    "type": "array",
+                    "description": "指定したリアクションがつけられていないノートを探します",
+                    "uniqueItems": true,
+                    "minItems": 1,
+                    "maxItems": 16,
+                    "items": {
+                      "type": "string"
+                    }
+                  },
                   "sinceId": {
                     "type": "string",
                     "description": "指定されたID以降のノートを返します",
@@ -61841,10 +61889,7 @@
                     "default": null,
                     "description": "ノートを作成したユーザーのID"
                   }
-                },
-                "required": [
-                  "query"
-                ]
+                }
               }
             }
           }
@@ -61881,6 +61926,15 @@
                       }
                     }
                   },
+                  "UNIMPLEMENTED": {
+                    "value": {
+                      "error": {
+                        "message": "Reaction Search is unimplemented",
+                        "code": "UNIMPLEMENTED",
+                        "id": "64d1dbf5-c14c-406e-88da-0f799b4b42ea"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {

Get diff files from Workflow Page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

検索キーワード無しのadvanced-search リアクション検索
2 participants