Use array for gradient slices instead of string to avoid weird comma

yomidevs · Nov 6, 2024 · 17b50db · 17b50db
1 parent 5f5ed52
commit 17b50db
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/ext/js/display/display-anki.js b/ext/js/display/display-anki.js
@@ -608,17 +608,17 @@ export class DisplayAnki {
         const gradientSliceSize = 100 / flags.size;
         let currentGradientPercent = 0;
 
-        let gradient = 'linear-gradient(to right,';
+        const gradientSlices = [];
         for (const flag of flags) {
             const flagColor = flagColorsDict[flag];
-            gradient += 'rgb(' + flagColor.red + ',' + flagColor.green + ',' + flagColor.blue + ') ' + currentGradientPercent + '%,';
-            gradient += 'rgb(' + flagColor.red + ',' + flagColor.green + ',' + flagColor.blue + ') ' + (currentGradientPercent + gradientSliceSize) + '%,';
+            gradientSlices.push(
+                'rgb(' + flagColor.red + ',' + flagColor.green + ',' + flagColor.blue + ') ' + currentGradientPercent + '%',
+                'rgb(' + flagColor.red + ',' + flagColor.green + ',' + flagColor.blue + ') ' + (currentGradientPercent + gradientSliceSize) + '%',
+            );
             currentGradientPercent += gradientSliceSize;
         }
-        gradient = gradient.slice(0, -1); // remove trailing comma
-        gradient += ')';
 
-        return gradient;
+        return 'linear-gradient(to right,' + gradientSlices.join(',') + ')';
     }
 
     /**