Fix infinite event listener ping-pong destroying settings page (#1308)

* Reject observer children updates from 'element' * Revert logic order switch in _onObserverChildrenUpdated
yomidevs · Aug 13, 2024 · a7c19ce · a7c19ce
1 parent 4cae317
commit a7c19ce
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/ext/js/dom/dom-data-binder.js b/ext/js/dom/dom-data-binder.js
@@ -209,10 +209,9 @@ export class DOMDataBinder {
      * @param {import('dom-data-binder').ElementObserver<T>} observer
      */
     _onObserverChildrenUpdated(element, observer) {
-        if (!observer.hasValue) {
-            return;
+        if (observer.hasValue && this._getNormalizedElementType(element) !== 'element') {
+            this._setElementValue(element, observer.value);
         }
-        this._setElementValue(element, observer.value);
     }
 
     /**