Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deinflection descriptions for Japanese #1053

Closed
jamesmaa opened this issue Jun 12, 2024 · 0 comments · Fixed by #1007
Closed

Add deinflection descriptions for Japanese #1053

jamesmaa opened this issue Jun 12, 2024 · 0 comments · Fixed by #1007
Labels
area/tech-debt good first issue The issue is a good starting point for first-time contributors triage/accepted The issue or PR is ready to be actively worked on

Comments

@jamesmaa
Copy link
Collaborator

Some of the deinflection rules in japanese-transforms.js are missing descriptions that could be helpful for folks learning Japanese.

Help write descriptions that increase the deinflection rule coverage of Japanese 🇯🇵 🙏
@jamesmaa jamesmaa added triage/accepted The issue or PR is ready to be actively worked on good first issue The issue is a good starting point for first-time contributors area/tech-debt labels Jun 12, 2024
@StefanVukovic99 StefanVukovic99 linked a pull request Jun 12, 2024 that will close this issue
[ja] Refactor Japanese transforms names and add English descriptions #1007
Merged
@Lyroxide Lyroxide mentioned this issue Jun 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tech-debt good first issue The issue is a good starting point for first-time contributors triage/accepted The issue or PR is ready to be actively worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ja] Refactor Japanese transforms names and add English descriptions Lyroxide/yomichan-korean
1 participant
@jamesmaa