-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] Refactor Japanese transforms names and add English descriptions #1007
Conversation
…-korean into add-transforms
c7587b9
to
cc78f4f
Compare
|
Yeah I know. Similar to adv, I'm thinking if other names are appropriate. It seems like there's no consistency. we have if you see some of the ja i18n, some of it are not exact translations of the english name. let me know your opinions because im way past a beginner and i do not know what would a beginner think when they see stuff like |
Ready for review. The main description has been updated to show the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a ton of work here, thanks 🧎♂️
I see this as 4 separate concerns:
- add descriptions
- rename inflections
- add causative inflections
- remove negative imperative
it'd probably be a pain to decouple 1 and 2, but i think you can move 3 and 4 into their own PRs
name: 'imperative negative', | ||
rules: [ | ||
suffixInflection('な', '', [], ['v']), | ||
'continuative form': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to hear more opinions on this one, since choosing whether we'll refer to this as masu stem
or continuative
impacts a lot of the other descriptions. I think it's worth keeping it as masu stem
since that seems more typical for beginner content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a hill I will die on to have this change. I don't know what beginner content you're referring to, but not everyone learnt grammar from the same resources that teach 'masu stem.' In fact, I never knew what was that until I used Yomichan. To clarify what is a stem,
書く
語幹=書
未然形=か、こ
連用形=き
終止形=く
連体形=く
仮定形=け
命令形=け
stem is the unchanging part of the word after inflection, i.e. the common part in its paradigm. Here, clearly the stem is 書, while some other sources would say 'kak' is the stem. How one would find the stem in English or other languages is irrelevant; in Japanese, nobody calls the 'part where you conjugate masu then drop the masu' the 'masu stem'.
Well, I don't want the deinflections to be littered with only linguistically accurate words, but this is a misnomer that I can't close an eye to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the nomenclature per se is very important, but this is a change to existing user-facing stuff so want to think it through.
For beginner content, the tmw guide/grammar recommends cure dolly, tae kim, DoJG.
Dolly calls it い-stem
, tae calls it the stem
. Both mention masu stem
but don't like it:
(dolly) In English it's sometimes called the "ます stem", which is not inaccurate because of course
it does, among many, many other things, connect the helper-verb "ます".
I don't like this expression because it stems from the whole ecology where
the so-called ます-form of verbs, which means verbs shifted into the い-stem
and having the "ます" helper verb attached to them, were the base-form of verbs.
(tae) This is often called the ます-stem in Japanese textbooks but we will call it just the stem because it is used in many more conjugations than just its ます -form.
Dolly mentions 連用形 a bit, neither mentions continuative
. DoJG seems to call it Vmasu
.
All of the options are bad in their own way...
CodSpeed Performance ReportMerging #1007 will not alter performanceComparing Summary
|
View Playwright Report (note: open the "playwright-report" artifact) |
In tandem with #1000
Closes #1053
This PR changes the following:
adv
->-ku
: adv is simply unclear.polite
->-masu
: to standardise suffix naming conventionpast
->-ta
: it has meanings other than past tense (a big beginner trap)masu stem
->continuative
: again, only to be found in English translations. ます語幹 is not a thing, but the 連用形.noun
->-sa
: to standardise namingprogressive or perfect
->-teiru
: has meanings other than progressive or perfectReferences:
imabi.org
新明解国語辞典 第八版
三省堂国語辞典 第八版
大辞林 第四版
JMdict