The green add button just dissapeared.

[todorpashkulov]

Description
The extension was working fine and all of a sudden the green add to anki button disappeared. No idea what broke it. Anki connect is working.

Browser version
Firefox 124.0.2

Yomitan version
Yomitan 24.4.7.0
Anki Version ⁨2.1.48

Exported settings file
yomitan-settings-2024-04-14-23-42-13.json

[todorpashkulov]

I found the problem when the setting.

Check for card duplicates
When a card is detected as a duplicate, the add buttons will be disabled.

Is enabled it detects all cards as duplicates and always hides the add buttons no idea if the problem is because of my anki version.

[Kuuuube]

It isn't supposed to hide the add buttons ever (disable != hide). But it's a bit misleading now. In previous versions it would gray them out but now they show as a red color when theres a duplicate and still let you add a dupe if you want.

[Kuuuube]

I cannot replicate this issue using the latest anki version. If you have a way to test on latest or can update that would be helpful.

[kanjieater]

I'm on a recent version (not yet latest) and am running into the same thing. If I disable the duplicate check at a Deck level it reenables the add button.
バージョン ⁨23.12.1 (1a1d4d54)⁩
Python 3.9.15 Qt 5.15.2 PyQt 5.15.5

[Kuuuube]

Are there any yomitan errors in console (F12 -> Console) when this happens?

[kanjieater]

Are there any yomitan errors in console (F12 -> Console) when this happens?

None relating to this functionality - these exist whether it's on or off

[joseph-allen]

I am having the same issue, I set up a few weeks ago on MacOS, came back today to study and the add/book icons are both now missing. I've done a fresh install of AnkiConnect & Yomitan and the same happens

[joseph-allen]

Not sure if intended, but I can get into the HTML and see the actions are there, and set to hidden and disabled. If I remove these qualities manually adding works, so the bug may be in the logic setting hidden and disabled.

[pavliuk-ii]

Same issue on my android phone (firefox 124.2.0, yomitan 24.4.7.0, ankidroid 2.17.6, ankiconnect mobile 1.12)
Disabling "Check for card duplicates" makes the buttons display, but then I have no idea if I already had the word added before which defeats the purpose of the function at all.
Just in case, I checked my pc setup and add duplicate button works as intended (firefox 125.0b9, yomitan 24.4.7.0, anki 23.12.1)

[joseph-allen]

I can't find the option for "Check for card duplicates" @pavliuk-ii, is that a Anki, Anki connect or Yomitan?

[pavliuk-ii]

@joseph-allen It's in the anki section of yomitan settings.

[joseph-allen]

Ah fantastic, it's an advanced setting in my settings but that's all I needed. And toggling that did make the add button return for me too

[pavliuk-ii]

Yeah, the biggest issue with disabling it is that when it's off you can't see which words you have mined before and which not and you end up with new duplicates every time

[Kuuuube]

Got the entire anki collection, yomitan settings, and yomitan dicts of someone with this issue. And I still can't replicate the issue.

I can try to look into fixing it but no guarantees since I currently have no way to test.

If anyone can figure out more specifically what is causing this that would be helpful. Or if anyone with this issue knows how to use git and can bisect and find the bad commit.

[Kuuuube]

Also @eloyrobillard since it's most likely #693 that is causing this if you have any insight here.

[genednzl]

Having the same problem, reset all settings on Yomitan but the green button still not showing up.
Even the scanning stopped working so really hoping someone can fix this.
Gonna try to disable the duplicate card option when im home see if that works like for everyone else

[eloyrobillard]

@Kuuuube I'll look into this asap

Not sure if intended, but I can get into the HTML and see the actions are there, and set to hidden and disabled. If I remove these qualities manually adding works, so the bug may be in the logic setting hidden and disabled.

that sounds plausible indeed

[Kuuuube]

Please try the latest pre release https://github.com/themoeway/yomitan/releases/tag/24.4.15.0 and see if you can replicate the bug there.

If it is present, check the console and it should now display some log about what when wrong.

[StefanVukovic99]

You can get 24.4.15.0 for chrome in the store also.

[YashaNoos]

I have the same problem as op. Just tested 24.4.15.0 and sadly the green add button didn't came back.

Kiwi Browser 124.0.6327.2
Android 14
Anki connect android 1.12
Anki 23.12.1

[Mansive]

Encountered this issue on Kiwi Browser 8265119645, Yomitan 24.4.15.0. I've pasted the console logs below:

Yomitan (development build) 24.4.15.0 has encountered a problem.
Originating URL: chrome-extension://ifgadlclliipkebdbniaddamapenidgc/popup.html?type=terms&query=%E9%82%AA%E6%82%AA&wildcards=off
ExtensionError: Anki error: com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 1 column 14 path $com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 1 column 14 path $
	at com.google.gson.JsonParser.parseReader(JsonParser.java:66)
	at com.google.gson.JsonParser.parseString(JsonParser.java:47)
	at com.kamwithk.ankiconnectandroid.routing.AnkiAPIRouting.findRouteHandleError(AnkiAPIRouting.java:101)
	at com.kamwithk.ankiconnectandroid.routing.APIHandler.chooseAPI(APIHandler.java:33)
	at com.kamwithk.ankiconnectandroid.routing.RouteHandler.get(RouteHandler.java:70)
	at fi.iki.elonen.router.RouterNanoHTTPD$DefaultStreamHandler.post(RouterNanoHTTPD.java:100)
	at fi.iki.elonen.router.RouterNanoHTTPD$UriResource.process(RouterNanoHTTPD.java:386)
	at fi.iki.elonen.router.RouterNanoHTTPD$UriRouter.process(RouterNanoHTTPD.java:596)
	at fi.iki.elonen.router.RouterNanoHTTPD.serve(RouterNanoHTTPD.java:671)
	at fi.iki.elonen.NanoHTTPD$HTTPSession.execute(NanoHTTPD.java:945)
	at fi.iki.elonen.NanoHTTPD$ClientHandler.run(NanoHTTPD.java:192)
	at java.lang.Thread.run(Thread.java:1012)
Caused by: com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 1 column 14 path $
	at com.google.gson.stream.JsonReader.syntaxError(JsonReader.java:1597)
	at com.google.gson.stream.JsonReader.checkLenient(JsonReader.java:1404)
	at com.google.gson.stream.JsonReader.doPeek(JsonReader.java:542)
	at com.google.gson.stream.JsonReader.peek(JsonReader.java:425)
	at com.google.gson.JsonParser.parseReader(JsonParser.java:61)
	... 11 more

    at AnkiConnect._invoke (chrome-extension://ifgadlclliipkebdbniaddamapenidgc/js/comm/anki-connect.js:441:31)
    at async AnkiConnect.canAddNotesWithErrorDetail (chrome-extension://ifgadlclliipkebdbniaddamapenidgc/js/comm/anki-connect.js:138:24)
    at async Backend.detectDuplicateNotes (chrome-extension://ifgadlclliipkebdbniaddamapenidgc/js/background/backend.js:547:16)
    at async Backend.partitionAddibleNotes (chrome-extension://ifgadlclliipkebdbniaddamapenidgc/js/background/backend.js:557:31)
    at async Backend._onApiGetAnkiNoteInfo (chrome-extension://ifgadlclliipkebdbniaddamapenidgc/js/background/backend.js:583:47)
Data: {
    "action": "canAddNotesWithErrorDetail",
    "params": {
        "notes": [
            {
                "fields": {
                    "Word": "邪悪",
                    "Reading": "じゃあく",
                    "Glossary": "<span class=\"dict-group__tag-list\"><span class=\"dict-group__tag dict-group__tag--dict\"><span class=\"dict-group__tag-inner\">旺文社国語辞典 第十一版 画像無し</span></span></span><span class=\"dict-group__glossary\"><span class=\"dict-group__glossary--first-line\">じゃ‐あく【邪悪】</span><span class=\"dict-group__glossary--first-line-break\"><br></span>（名・形動ダ）心がねじけていて悪いこと。また、そのさま。「―な心」</span>",
                    "Sentence": "黒と赤のフリフリたっぷりリボンマシマシのドレスを着た闇聖女は、どす黒いオーラを放ついかにも<b>邪悪</b>な顔で笑い、強大な光の攻撃魔法を次から次へと繰り出して、辺りのものを破壊しまくっている。",
                    "Picture": "",
                    "Audio": "",
                    "SentenceAudio": "",
                    "Graph": "",
                    "Hint": "",
                    "Source": "キラキラネームの『破滅の闇聖女』にはなりません！（サーガフォレスト）１ | ッツ Ebook Reader"
                },
                "tags": [
                    "yomichan",
                    "onyx"
                ],
                "deckName": "日本語::Mining",
                "modelName": "Mining-475ae",
                "options": {
                    "allowDuplicate": false,
                    "duplicateScope": "collection",
                    "duplicateScopeOptions": {
                        "deckName": null,
                        "checkChildren": false,
                        "checkAllModels": true
                    }
                }
            },
            {
                "fields": {
                    "Word": "じゃあく",
                    "Reading": "",
                    "Glossary": "<span class=\"dict-group__tag-list\"><span class=\"dict-group__tag dict-group__tag--dict\"><span class=\"dict-group__tag-inner\">旺文社国語辞典 第十一版 画像無し</span></span></span><span class=\"dict-group__glossary\"><span class=\"dict-group__glossary--first-line\">じゃ‐あく【邪悪】</span><span class=\"dict-group__glossary--first-line-break\"><br></span>（名・形動ダ）心がねじけていて悪いこと。また、そのさま。「―な心」</span>",
                    "Sentence": "黒と赤のフリフリたっぷりリボンマシマシのドレスを着た闇聖女は、どす黒いオーラを放ついかにも<b>邪悪</b>な顔で笑い、強大な光の攻撃魔法を次から次へと繰り出して、辺りのものを破壊しまくっている。",
                    "Picture": "",
                    "Audio": "",
                    "SentenceAudio": "",
                    "Graph": "",
                    "Hint": "",
                    "Source": "キラキラネームの『破滅の闇聖女』にはなりません！（サーガフォレスト）１ | ッツ Ebook Reader"
                },
                "tags": [
                    "yomichan",
                    "onyx"
                ],
                "deckName": "日本語::Mining",
                "modelName": "Mining-475ae",
                "options": {
                    "allowDuplicate": false,
                    "duplicateScope": "collection",
                    "duplicateScopeOptions": {
                        "deckName": null,
                        "checkChildren": false,
                        "checkAllModels": true
                    }
                }
            },
            {
                "fields": {
                    "Word": "邪",
                    "Reading": "じゃ",
                    "Glossary": "<ol><li data-details=\"旺文社国語辞典 第十一版 画像無し\"><span class=\"dict-group__tag-list\"><span class=\"dict-group__tag dict-group__tag--dict\"><span class=\"dict-group__tag-inner\">旺文社国語辞典 第十一版 画像無し</span></span></span><span class=\"dict-group__glossary\"><span class=\"dict-group__glossary--first-line\">じゃ【邪】</span><span class=\"dict-group__glossary--first-line-break\"><br></span>ジャ㊥・ヤ<br>よこしま<br>筆順：<br><br>（字義）<br>① よこしま。正しくない。いつわり。心がねじけている。わるもの。「邪悪・邪推・邪説・邪道・正邪・破邪」<br>② 人の病（やまい）を起こさせる悪気。ばけものなど害をなすもの。「邪鬼・邪神・風邪（ふうじや・かぜ）」</span></li><li data-details=\"旺文社国語辞典 第十一版 画像無し\"><span class=\"dict-group__tag-list\"><span class=\"dict-group__tag dict-group__tag--dict\"><span class=\"dict-group__tag-inner\">旺文社国語辞典 第十一版 画像無し</span></span></span><span class=\"dict-group__glossary\"><span class=\"dict-group__glossary--first-line\">じゃ【邪】</span><span class=\"dict-group__glossary--first-line-break\"><br></span>よこしま。不正。「―は正に勝たず」<br>⇔正(1)：正(2)</span></li></ol>",
                    "Sentence": "黒と赤のフリフリたっぷりリボンマシマシのドレスを着た闇聖女は、どす黒いオーラを放ついかにも<b>邪</b>悪な顔で笑い、強大な光の攻撃魔法を次から次へと繰り出して、辺りのものを破壊しまくっている。",
                    "Picture": "",
                    "Audio": "",
                    "SentenceAudio": "",
                    "Graph": "",
                    "Hint": "",
                    "Source": "キラキラネームの『破滅の闇聖女』にはなりません！（サーガフォレスト）１ | ッツ Ebook Reader"
                },
                "tags": [
                    "yomichan",
                    "onyx"
                ],
                "deckName": "日本語::Mining",
                "modelName": "Mining-475ae",
                "options": {
                    "allowDuplicate": false,
                    "duplicateScope": "collection",
                    "duplicateScopeOptions": {
                        "deckName": null,
                        "checkChildren": false,
                        "checkAllModels": true
                    }
                }
            },
            {
                "fields": {
                    "Word": "じゃ",
                    "Reading": "",
                    "Glossary": "<ol><li data-details=\"旺文社国語辞典 第十一版 画像無し\"><span class=\"dict-group__tag-list\"><span class=\"dict-group__tag dict-group__tag--dict\"><span class=\"dict-group__tag-inner\">旺文社国語辞典 第十一版 画像無し</span></span></span><span class=\"dict-group__glossary\"><span class=\"dict-group__glossary--first-line\">じゃ【邪】</span><span class=\"dict-group__glossary--first-line-break\"><br></span>ジャ㊥・ヤ<br>よこしま<br>筆順：<br><br>（字義）<br>① よこしま。正しくない。いつわり。心がねじけている。わるもの。「邪悪・邪推・邪説・邪道・正邪・破邪」<br>② 人の病（やまい）を起こさせる悪気。ばけものなど害をなすもの。「邪鬼・邪神・風邪（ふうじや・かぜ）」</span></li><li data-details=\"旺文社国語辞典 第十一版 画像無し\"><span class=\"dict-group__tag-list\"><span class=\"dict-group__tag dict-group__tag--dict\"><span class=\"dict-group__tag-inner\">旺文社国語辞典 第十一版 画像無し</span></span></span><span class=\"dict-group__glossary\"><span class=\"dict-group__glossary--first-line\">じゃ【邪】</span><span class=\"dict-group__glossary--first-line-break\"><br></span>よこしま。不正。「―は正に勝たず」<br>⇔正(1)：正(2)</span></li></ol>",
                    "Sentence": "黒と赤のフリフリたっぷりリボンマシマシのドレスを着た闇聖女は、どす黒いオーラを放ついかにも<b>邪</b>悪な顔で笑い、強大な光の攻撃魔法を次から次へと繰り出して、辺りのものを破壊しまくっている。",
                    "Picture": "",
                    "Audio": "",
                    "SentenceAudio": "",
                    "Graph": "",
                    "Hint": "",
                    "Source": "キラキラネームの『破滅の闇聖女』にはなりません！（サーガフォレスト）１ | ッツ Ebook Reader"
                },
                "tags": [
                    "yomichan",
                    "onyx"
                ],
                "deckName": "日本語::Mining",
                "modelName": "Mining-475ae",
                "options": {
                    "allowDuplicate": false,
                    "duplicateScope": "collection",
                    "duplicateScopeOptions": {
                        "deckName": null,
                        "checkChildren": false,
                        "checkAllModels": true
                    }
                }
            },
            {
                "fields": {
                    "Word": "邪",
                    "Reading": "よこしま",
                    "Glossary": "<span class=\"dict-group__tag-list\"><span class=\"dict-group__tag dict-group__tag--dict\"><span class=\"dict-group__tag-inner\">旺文社国語辞典 第十一版 画像無し</span></span></span><span class=\"dict-group__glossary\"><span class=\"dict-group__glossary--first-line\">よこしま【◇邪】</span><span class=\"dict-group__glossary--first-line-break\"><br></span>（名・形動ダ）正しくないこと。道理にはずれていること。また、そのさま。「―な心」</span>",
                    "Sentence": "黒と赤のフリフリたっぷりリボンマシマシのドレスを着た闇聖女は、どす黒いオーラを放ついかにも<b>邪</b>悪な顔で笑い、強大な光の攻撃魔法を次から次へと繰り出して、辺りのものを破壊しまくっている。",
                    "Picture": "",
                    "Audio": "",
                    "SentenceAudio": "",
                    "Graph": "",
                    "Hint": "",
                    "Source": "キラキラネームの『破滅の闇聖女』にはなりません！（サーガフォレスト）１ | ッツ Ebook Reader"
                },
                "tags": [
                    "yomichan",
                    "onyx"
                ],
                "deckName": "日本語::Mining",
                "modelName": "Mining-475ae",
                "options": {
                    "allowDuplicate": false,
                    "duplicateScope": "collection",
                    "duplicateScopeOptions": {
                        "deckName": null,
                        "checkChildren": false,
                        "checkAllModels": true
                    }
                }
            },
            {
                "fields": {
                    "Word": "よこしま",
                    "Reading": "",
                    "Glossary": "<span class=\"dict-group__tag-list\"><span class=\"dict-group__tag dict-group__tag--dict\"><span class=\"dict-group__tag-inner\">旺文社国語辞典 第十一版 画像無し</span></span></span><span class=\"dict-group__glossary\"><span class=\"dict-group__glossary--first-line\">よこしま【◇邪】</span><span class=\"dict-group__glossary--first-line-break\"><br></span>（名・形動ダ）正しくないこと。道理にはずれていること。また、そのさま。「―な心」</span>",
                    "Sentence": "黒と赤のフリフリたっぷりリボンマシマシのドレスを着た闇聖女は、どす黒いオーラを放ついかにも<b>邪</b>悪な顔で笑い、強大な光の攻撃魔法を次から次へと繰り出して、辺りのものを破壊しまくっている。",
                    "Picture": "",
                    "Audio": "",
                    "SentenceAudio": "",
                    "Graph": "",
                    "Hint": "",
                    "Source": "キラキラネームの『破滅の闇聖女』にはなりません！（サーガフォレスト）１ | ッツ Ebook Reader"
                },
                "tags": [
                    "yomichan",
                    "onyx"
                ],
                "deckName": "日本語::Mining",
                "modelName": "Mining-475ae",
                "options": {
                    "allowDuplicate": false,
                    "duplicateScope": "collection",
                    "duplicateScopeOptions": {
                        "deckName": null,
                        "checkChildren": false,
                        "checkAllModels": true
                    }
                }
            }
        ]
    },
    "status": 200,
    "apiError": "com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 1 column 14 path $com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 1 column 14 path $\n\tat com.google.gson.JsonParser.parseReader(JsonParser.java:66)\n\tat com.google.gson.JsonParser.parseString(JsonParser.java:47)\n\tat com.kamwithk.ankiconnectandroid.routing.AnkiAPIRouting.findRouteHandleError(AnkiAPIRouting.java:101)\n\tat com.kamwithk.ankiconnectandroid.routing.APIHandler.chooseAPI(APIHandler.java:33)\n\tat com.kamwithk.ankiconnectandroid.routing.RouteHandler.get(RouteHandler.java:70)\n\tat fi.iki.elonen.router.RouterNanoHTTPD$DefaultStreamHandler.post(RouterNanoHTTPD.java:100)\n\tat fi.iki.elonen.router.RouterNanoHTTPD$UriResource.process(RouterNanoHTTPD.java:386)\n\tat fi.iki.elonen.router.RouterNanoHTTPD$UriRouter.process(RouterNanoHTTPD.java:596)\n\tat fi.iki.elonen.router.RouterNanoHTTPD.serve(RouterNanoHTTPD.java:671)\n\tat fi.iki.elonen.NanoHTTPD$HTTPSession.execute(NanoHTTPD.java:945)\n\tat fi.iki.elonen.NanoHTTPD$ClientHandler.run(NanoHTTPD.java:192)\n\tat java.lang.Thread.run(Thread.java:1012)\nCaused by: com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 1 column 14 path $\n\tat com.google.gson.stream.JsonReader.syntaxError(JsonReader.java:1597)\n\tat com.google.gson.stream.JsonReader.checkLenient(JsonReader.java:1404)\n\tat com.google.gson.stream.JsonReader.doPeek(JsonReader.java:542)\n\tat com.google.gson.stream.JsonReader.peek(JsonReader.java:425)\n\tat com.google.gson.JsonParser.parseReader(JsonParser.java:61)\n\t... 11 more\n"
}

Issues can be reported at https://github.com/themoeway/yomitan/issues

[Kuuuube]

This may be related to the android ankiconnect + kiwi browser issues KamWithK/AnkiconnectAndroid#50

If anyone who is experiencing this issue on pc can get a log from the pre release that would be helpful.

[Kuuuube]

@eloyrobillard would it be possible to add a fallback using the previous "check for duplicates" ankiconnect api call if the current one fails? canAddNotesWithErrorDetail seems to be too new in some cases

[Kuuuube]

Error log from a user on PC, sent on tmw discord. errorlog.txt

Appears to be an ankiconnect error caused by canAddNotesWithErrorDetail and an outdated version of ankiconnect.

[Kuuuube]

For any users experiencing this on pc make sure you have ankiconnect updated to the latest version. This may require deleting and reinstalling the ankiconnect addon.

It appears that some older anki versions may not be receiving new ankiconnect updates so you may have to update anki as well.

[kanjieater]

For any users experiencing this on pc make sure you have ankiconnect updated to the latest version. It appears that some older anki versions may not be receiving new ankiconnect updates so you may have to update anki as well.

I can confirm that updating anki connect allows me to reenable the duplicate setting, same as before this release.

However, it seems the new code does not disable adding duplicates at a deck level like it did previously.
If you accidentally double click the "add card button that then becomes the add duplicate button", it adds a duplicate to your deck, which isn't how it used to work. It used to just disable adding a duplicate card once it was in the deck.

[Kuuuube]

However, it seems the new code does not disable adding duplicates at a deck level like it did previously. If you accidentally double click the "add card button that then becomes the add duplicate button", it adds a duplicate to your deck, which isn't how it used to work. It used to just disable adding a duplicate card once it was in the deck.

This duplicate button not being disabled and instead just turning into the new "add duplicate" button is intended. It may be a good idea to make a timeout to prevent issues with double clicking it. You can make another issue to request that or similar.

[eloyrobillard]

@eloyrobillard would it be possible to add a fallback using the previous "check for duplicates" ankiconnect api call if the current one fails? canAddNotesWithErrorDetail seems to be too new in some cases

yes, I'll do that

[eloyrobillard]

I've prepared a fix in #827