Fix UTF32 characters breaking sentence parser due directly accessing string array indexes #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…string array indexes
Kuuuube
added
kind/bug
jamesmaa
approved these changes
Oct 3, 2024
austinyu12
pushed a commit
to austinyu12/yomitan
that referenced
this pull request
Oct 22, 2024
…string array indexes (yomidevs#1452)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UTF32 characters take up two indexes in JS strings and the sentence parser was indexing the string directly causing an incorrect offset to be applied to the sentence. This causes the
{cloze-prefix},{cloze-body}, and{cloze-suffix}handlebars to select the wrong text.Converting the text to an array before parsing combines UTF32 characters into a single index.
Discovered on this page: https://learnjapanese.moe/texthooker.html. It has a UTF32 emoji character in the top right (🚫) which gets pulled into the sentence parser.