Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Dev Dependencies #1528

Merged
merged 5 commits into from
Oct 27, 2024
Merged

Bump Dev Dependencies #1528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3246650
Bump stuff
MarvNC Oct 26, 2024
445984b
Bump stuff and revert ts to fix ts expect error
MarvNC Oct 26, 2024
0a04fa1
Bump micromatch because vuln
MarvNC Oct 26, 2024
44858cb
Remove dependency
MarvNC Oct 26, 2024
a9f8141
Merge branch 'master' into bump-stuff
MarvNC Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,6 @@
],
"url": "/ext/data/schemas/recommended-dictionaries-schema.json"
}
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so vscode uses the workspace version of ts and doesn't yell at you about stuff that's erroring in the latest version

],
"typescript.tsdk": "node_modules\\typescript\\lib"
}
1 change: 1 addition & 0 deletions ext/js/core/utilities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ export function deferPromise() {
let resolve;
/** @type {((reason?: import('core').RejectionReason) => void)|undefined} */
let reject;
/** @type {Promise<T>} */
const promise = new Promise((resolve2, reject2) => {
resolve = resolve2;
reject = reject2;
Expand Down
1 change: 1 addition & 0 deletions ext/js/dictionary/dictionary-data-util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ export function groupKanjiFrequencies(sourceFrequencies) {
export function getGroupedPronunciations(dictionaryEntry) {
const {headwords, pronunciations: termPronunciations} = dictionaryEntry;

/** @type {Set<string>} */
const allTerms = new Set();
const allReadings = new Set();
/** @type {Map<string, string>} */
Expand Down
Loading
Loading