Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dictionary will preserve its settings #1553

Merged
merged 13 commits into from
Nov 4, 2024
Merged

Update dictionary will preserve its settings #1553

merged 13 commits into from
Nov 4, 2024

Conversation

khaitruong922
Copy link

Fixes #1488

Preserve dictionary position and settings across all profiles after update (except title)

@khaitruong922 khaitruong922 requested a review from a team as a code owner October 31, 2024 16:24
@khaitruong922 khaitruong922 marked this pull request as draft October 31, 2024 16:34
@khaitruong922
Copy link
Author

khaitruong922 commented Oct 31, 2024 •
edited
Loading

This will break if user moves or deletes profile during update (probably not cause any crash due to the condition check but the order and settings will be messed up between profiles)

@khaitruong922 khaitruong922 marked this pull request as ready for review November 2, 2024 06:31
@khaitruong922
Copy link
Author

Ready for review

Add id for profile since currently there is no unique identifier for profile.
Update dictionary will now work even if the user deletes or swaps the profiles since it will map the profile id with its dictionary settings.

@MarvNC MarvNC added this pull request to the merge queue Nov 4, 2024
Merged via the queue into yomidevs:master with commit d09cd38 Nov 4, 2024
11 checks passed
@khaitruong922 khaitruong922 mentioned this pull request Nov 5, 2024
Merged
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvNC MarvNC MarvNC approved these changes

Assignees
No one assigned
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating dictionaries resets their positioning
3 participants
@khaitruong922 @MarvNC @Kuuuube