Set editing profile index correctly when deleting profile #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmaa
previously approved these changes
Nov 4, 2024
jamesmaa
dismissed
their stale review
Sorry didn't read it carefully. Have a question or two in a bit
jamesmaa
reviewed
Nov 4, 2024
| @@ -261,6 +261,10 @@ export class ProfileController { | |||
| // Update profile index | |||
| if (settingsProfileIndex === profileIndex) { | |||
There was a problem hiding this comment.
Suggested change
| if (settingsProfileIndex === profileIndex) { | |
| if (settingsProfileIndex >= profileIndex) { |
Isn't this math accounted for above? Line 231
if (profileCurrentNew >= profileIndex) {
profileCurrentNew = Math.min(profileCurrentNew - 1, this._profiles.length - 1);
modifications.push({
action: 'set',
path: 'profileCurrent',
value: profileCurrentNew,
});
}
| @@ -261,6 +261,10 @@ export class ProfileController { | |||
| // Update profile index | |||
| if (settingsProfileIndex === profileIndex) { | |||
There was a problem hiding this comment.
Also what's the difference between settingsProfileIndex and profileIndex?
There was a problem hiding this comment.
settingsProfileIndex is editing profile index, profileIndex is the index to be deleted. Maybe should rename this?
This reverts commit 4d81d24.
jamesmaa
approved these changes
Nov 4, 2024
Playwright test results
Details
Flaky testschromium › integration.spec.js › anki add |
Kuuuube
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1556
Let's call editing profile index
xand deleted profile indexyCurrently we does not handle:
x < y: The default profile and editing profile will be reset to the first profile, however when reload the page, it still has the value before reset. Additionally, the radio button does not represent the default profile correctly. Calling_setProfileIndexwith the samexvalue will resolve this.x > y: The editing profile index is not shifted up, therefore it moves into below profile. When the editing profile is the last index, it will cause index error, and we cannot add more profiles after that. The issue happens because when we add a profile, the editing profile index is set to last index.List indexes are also updated correctly after deletion.