forked from FooSoft/yomichan
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Anki card flags #1571
Open
Kuuuube
wants to merge
17
commits into
yomidevs:master
Choose a base branch
from
Kuuuube:show-flags
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Show Anki card flags #1571
+219
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/enhancement
The issue or PR is a new feature or request
area/ui-ux
The issue or PR is related to UI/UX/Design
area/anki
The issue or PR is related to Anki integration
labels
Nov 5, 2024
Support for flags has been merged into AnkiConnect. This PR is no longer blocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/anki
The issue or PR is related to Anki integration
area/ui-ux
The issue or PR is related to UI/UX/Design
kind/enhancement
The issue or PR is a new feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333
Blocking on AnkiConnect lacking support for flags. I've contacted foosoft to get support for this merged in. Currently using this patch to test: 0001-Add-support-for-flags.txt.Older AnkiConnect versions without flag support will still work fine, there are no errors, it just wont be able to show any flags.