Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant line #1577

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Remove redundant line #1577

merged 1 commit into from
Nov 6, 2024
+0 −1

Conversation

khaitruong922
Copy link

Remove redundant line from #1561

@khaitruong922 khaitruong922 requested a review from a team as a code owner November 6, 2024 19:20
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #1577 will improve performances by 32.51%

Comparing khaitruong922:remove-line (3890bac) with master (c95b938)

Summary

⚡ 1 improvements
✅ 2 untouched benchmarks

Benchmarks breakdown

Benchmark master khaitruong922:remove-line Change
⚡ japanese transformations-full (n=212) 64.2 ms 48.4 ms +32.51%

@jamesmaa jamesmaa added this pull request to the merge queue Nov 6, 2024
Merged via the queue into yomidevs:master with commit 77edfc7 Nov 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmaa jamesmaa jamesmaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khaitruong922 @jamesmaa