Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @types/node to 20.11.5 and pin #637

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

toasted-nutbread
Copy link

Fixes the issue with #618 causing a typescript conflict. Pinning the version for now will make it so it won't break again.

vitejs/vite#15714

@toasted-nutbread toasted-nutbread requested a review from a team as a code owner February 4, 2024 17:17
Copy link

codspeed-hq bot commented Feb 4, 2024

CodSpeed Performance Report

Merging #637 will not alter performance

Comparing toasted-nutbread:update-node-types (a56fa60) with master (6b327e0)

Summary

✅ 1 untouched benchmarks

Copy link

github-actions bot commented Feb 4, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

Copy link
Collaborator

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- what will allow us to unpin it?

@djahandarie djahandarie added this pull request to the merge queue Feb 5, 2024
Merged via the queue into yomidevs:master with commit 0e7531b Feb 5, 2024
7 checks passed
@toasted-nutbread
Copy link
Author

Pinning is just done by removing the "^" prefix in the package.json dependency version, making it no longer follow semver.

@djahandarie djahandarie added the kind/meta The issue or PR is meta label Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants