Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tags not displaying for duplicate cards #819

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix tags not displaying for duplicate cards #819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions ext/js/background/backend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,10 +609,14 @@ export class Backend {

const valid = isNoteDataValid(note);

const noteIds = isDuplicate ? duplicateNoteIds[originalIndices.indexOf(i)] : null;
const noteInfos = (fetchAdditionalInfo && noteIds !== null && noteIds.length > 0) ? await this._anki.notesInfo(noteIds) : [];

const info = {
Kuuuube marked this conversation as resolved.
Show resolved Hide resolved
canAdd: valid,
valid,
noteIds: isDuplicate ? duplicateNoteIds[originalIndices.indexOf(i)] : null
noteIds: noteIds,
noteInfos: noteInfos
};

results.push(info);
Expand All @@ -622,20 +626,6 @@ export class Backend {
}
Kuuuube marked this conversation as resolved.
Show resolved Hide resolved
}

if (cannotAdd.length > 0) {
const cannotAddNotes = cannotAdd.map(({note}) => note);
const noteIdsArray = await this._anki.findNoteIds(cannotAddNotes);
for (let i = 0, ii = Math.min(cannotAdd.length, noteIdsArray.length); i < ii; ++i) {
const noteIds = noteIdsArray[i];
if (noteIds.length > 0) {
cannotAdd[i].info.noteIds = noteIds;
if (fetchAdditionalInfo) {
cannotAdd[i].info.noteInfos = await this._anki.notesInfo(noteIds);
}
}
}
}

return results;
}

Expand Down