Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect calculation in indexTree.treePosToPath operation #158

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented Feb 22, 2024

What this PR does / why we need it?

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 added the bug 🐞 Something isn't working label Feb 22, 2024
@7hong13 7hong13 added this to the 0.4.15 milestone Feb 22, 2024
@7hong13 7hong13 self-assigned this Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0f64efb) 79.61% compared to head (a26048d) 79.63%.

Files Patch % Lines
...orkie/src/main/kotlin/dev/yorkie/util/IndexTree.kt 78.57% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   79.61%   79.63%   +0.02%     
==========================================
  Files          63       63              
  Lines        3851     3855       +4     
  Branches      604      606       +2     
==========================================
+ Hits         3066     3070       +4     
  Misses        459      459              
  Partials      326      326              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@7hong13 7hong13 merged commit 79f4573 into main Feb 23, 2024
6 checks passed
@7hong13 7hong13 deleted the fix_index_tree branch February 23, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants