Add more Tree concurrency tests

[7hong13]

What this PR does / why we need it?

I added more tests which were previously skipped on the JS SDK.

Any background context you want to provide?

What are the relevant tickets?

• Add Tree concurrency tests yorkie-js-sdk#792

Fixes #

Checklist

• Added relevant tests or not required
• Didn't break anything

Summary by CodeRabbit

• New Features

  • Introduced new test methods to improve testing coverage for concurrent operations.

• Chores

  • Updated application version to 0.4.21-rc.

[coderabbitai]

Walkthrough

The recent updates primarily focus on versioning and concurrency testing. The gradle.properties file was updated to reflect a new release candidate version. Concurrently, the JsonTreeConcurrencyTest.kt file saw significant enhancements with new test methods and modifications to existing ones, aimed at improving the robustness of concurrency handling in JSON document operations.

Changes

Files	Change Summary
gradle.properties	Updated VERSION_NAME from 0.4.20 to 0.4.21-rc.
.../JsonTreeConcurrencyTest.kt	Added imports for StyleOpCode and @Ignore; introduced new test methods; modified existing test methods.

Poem

In the realm of code so bright,
A version shifts to new delight,
Tests for JSON, strong and true,
Concurrency now bids adieu.
With each commit, we strive and grow,
In this dance of dev, we glow.
🌟🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3fe3a6f and 0e3702c.

Files selected for processing (2)

• gradle.properties (1 hunks)
• yorkie/src/androidTest/kotlin/dev/yorkie/document/json/JsonTreeConcurrencyTest.kt (4 hunks)

Files skipped from review due to trivial changes (1)

• gradle.properties

Additional comments not posted (6)

yorkie/src/androidTest/kotlin/dev/yorkie/document/json/JsonTreeConcurrencyTest.kt (6)

7-7: Added import for StyleOpCode is appropriate for the new test methods that use style operations.

---

15-15: Added import for Ignore annotation. Ensure it's used appropriately to skip tests that are not ready or are waiting for dependencies.

---

215-296: New test method test_concurrent_style_and_style added. This method tests concurrent style operations on text nodes. The test setup and assertions appear to be correctly implemented.

---

387-394: In test_concurrent_edit_and_style, the references to StyleOpCode have been updated correctly from OpCode.StyleOpCode to StyleOpCode.StyleRemove and StyleOpCode.StyleSet. This change aligns with the new import and simplifies the code.

---

412-515: The test_concurrent_split_and_split method is correctly marked with @Ignore due to dependencies on the JS SDK. This is a good practice to prevent the test from failing builds while the dependent features are not implemented. The test logic itself, which involves complex nested elements and split operations, seems well-structured and should effectively test the intended concurrency scenarios once enabled.

---

517-652: The test_concurrent_split_and_edit method is also marked with @Ignore for the same reasons as the previous test. The test setup involves complex operations combining splits and edits, which are crucial for testing the robustness of the concurrency model in the SDK. The method is well-prepared for future activation.
[APROVED]

Verification successful

---

The recent commits and pull requests in the JS SDK repository indicate that significant work has been done on concurrency and edit operations, including the implementation of tree concurrency tests and handling concurrent edits. This suggests that the necessary features for the test_concurrent_split_and_edit test might now be in place.

• Commit dc60203367b5bc19173023d7c0307e8becbe44d1 implements tree_concurrency_test.ts.
• PR #792 adds tree concurrency tests.
• PR #805 handles Tree.toXML to return proper XML string.
• PR #611 handles concurrent cases for Yorkie.tree.
• PR #709 supports concurrent insertion and splitting in Tree.
• PR #712 generates correct TreeChange in concurrent edits.

These updates suggest that the concurrency model and edit operations have been enhanced and tested in the JS SDK.

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that the JS SDK has implemented the necessary features for this test.
# Test: Check for updates or issues related to this test in the JS SDK repository.

gh issue list -R yorkie-team/yorkie-js-sdk --search "edit operations in concurrency tests"

Length of output: 92

---

---

Script:

#!/bin/bash
# Description: Check for recent commits in the JS SDK repository related to concurrency or edit operations.
gh repo clone yorkie-team/yorkie-js-sdk
cd yorkie-js-sdk
git log --since="6 months ago" --grep="concurrency" --grep="edit operations"

# Description: Check for recent pull requests in the JS SDK repository related to concurrency or edit operations.
gh pr list -R yorkie-team/yorkie-js-sdk --search "concurrency" --state all
gh pr list -R yorkie-team/yorkie-js-sdk --search "edit operations" --state all

Length of output: 2856