Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process of tree style change #170

Merged
merged 2 commits into from
May 21, 2024
Merged

Fix process of tree style change #170

merged 2 commits into from
May 21, 2024

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented May 21, 2024

What this PR does / why we need it:

  • RHT that storing attributes is shallowly copied, So the style set does not perform at yorkie tree.
  • Remove unnecessary code.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum requested a review from myupage May 21, 2024 08:44
@humdrum humdrum self-assigned this May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 38.89%. Comparing base (e309688) to head (b8eeff9).

Files Patch % Lines
Sources/Document/CRDT/CRDTTree.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   38.89%   38.89%           
=======================================
  Files         105      105           
  Lines       18895    18893    -2     
=======================================
  Hits         7349     7349           
+ Misses      11546    11544    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@myupage myupage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@humdrum humdrum merged commit 294fd38 into main May 21, 2024
3 checks passed
@humdrum humdrum deleted the fix-style branch May 21, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants