Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Prometheus metrics #76

Closed
hackerwins opened this issue Aug 13, 2020 · 2 comments · Fixed by #80
Closed

Introduce Prometheus metrics #76

hackerwins opened this issue Aug 13, 2020 · 2 comments · Fixed by #80
Labels
enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers

Comments

@hackerwins
Copy link
Member

hackerwins commented Aug 13, 2020

Yorkie is getting more complex as features are added. So, we need to monitor the status of Agent.
It would be nice to support Prometheus /metrics and monitor them in yorkie.dev.

@hackerwins hackerwins added enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers labels Aug 13, 2020
@daclouds
Copy link
Contributor

Could I try this issue?

before I start, I have a question.
Is there any custom application-specific metrics we need?
(In the example of etcd, custom metrics related to leader are registered.)

@hackerwins
Copy link
Member Author

@daclouds Sure. Thank you for your interest in this issue.

I think We need to record snapshot related metrics.

Also, I think It would be nice to save the basics at the beginning of the work(e.g. currentVersion, currentGoVersion).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants