Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Prometheus metrics #80

Merged
merged 11 commits into from
Aug 21, 2020
Merged

Introduce Prometheus metrics #80

merged 11 commits into from
Aug 21, 2020

Conversation

hackerwins
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test

/kind feature

What this PR does / why we need it:

Yorkie is getting more complex as features are added. So, we need to monitor the status of Agent.
This PR introduces prometheus and shows you how to add application specific metrics.

Which issue(s) this PR fixes:

Fixes #76

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:

- [Instrumenting a Go application for prometheus]: https://prometheus.io/docs/guides/go-application/

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #80 into master will decrease coverage by 0.20%.
The diff coverage is 34.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   55.55%   55.35%   -0.21%     
==========================================
  Files          23       23              
  Lines        2709     2728      +19     
==========================================
+ Hits         1505     1510       +5     
- Misses       1107     1123      +16     
+ Partials       97       95       -2     
Impacted Files Coverage Δ
yorkie/config.go 13.88% <0.00%> (-1.27%) ⬇️
yorkie/yorkie.go 0.00% <0.00%> (ø)
yorkie/rpc/server.go 44.72% <100.00%> (+1.68%) ⬆️
pkg/llrb/llrb.go 76.55% <0.00%> (-1.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a163e...f0f6a17. Read the comment docs.

@hackerwins hackerwins merged commit 001c7ac into master Aug 21, 2020
@hackerwins hackerwins deleted the feature/prometheus branch August 21, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Prometheus metrics
2 participants