Delete removed elements from the clone while running GC #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerwins
force-pushed
the
fix-clone-leak-on-gc
branch
from
d73744c
to
690d97f
Compare
|
As a result of testing, I confirmed that it works normally. 👍 |
hackerwins
force-pushed
the
fix-clone-leak-on-gc
branch
from
690d97f
to
d8527b2
Compare
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 55.86% 55.89% +0.03%
==========================================
Files 27 27
Lines 2515 2517 +2
==========================================
+ Hits 1405 1407 +2
Misses 1018 1018
Partials 92 92
Continue to review full report at Codecov.
|
When initially designing the GC, it was implemented so that only removed elements from the original were deleted. However, to solve the problem of accumulating removed elements in the clone, they are also deleted.
hackerwins
force-pushed
the
fix-clone-leak-on-gc
branch
from
d8527b2
to
3af2077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Delete removed elements from the clone while running GC
When initially designing the GC, it was implemented so that only removed
elements from the original were deleted. However, to solve the problem
of accumulating removed elements in the clone, they are also deleted.
Which issue(s) this PR fixes:
Fixes #100 and Related to yorkie-team/yorkie-js-sdk#101
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation: