Fix check already attached document #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In AttachDocument, [ErrDocumentAlreadyAttached] error is returned if there is a document in the current client field. However, AttachDocument also need to check the document attachment status to determine whether to return an error or not.
semin-park
approved these changes
Dec 3, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
In AttachDocument,
ErrDocumentAlreadyAttachederror is returned ifthere is a document in the current client field. However, AttachDocument
also needs to check the document attachment status to determine whether to
return an error or not.
Which issue(s) this PR fixes:
Fixes yorkie-team/yorkie-js-sdk#111
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation: