-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the type of client_id and actor_id in protobuf #145
Replace the type of client_id and actor_id in protobuf #145
Conversation
A 24 bytes hex-encoded string can be replaced with a 12 bytes of array to reduce size of marshalled data with Protobuf.
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 56.99% 57.05% +0.06%
==========================================
Files 33 33
Lines 3090 3106 +16
==========================================
+ Hits 1761 1772 +11
- Misses 1152 1154 +2
- Partials 177 180 +3
Continue to review full report at Codecov.
|
@autumn-n Thank you for sending PR. We'll review this soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the wonderful work 👍
I left some amendments and questions. After checking, please be honest with your opinion.
Question
I think the modify the JS SDK also needs to be done to profile this PR. If you let me know if you're modifying the JS SDK, I think we'll see how we can help.
Are you modifying the JS SDK?
About test
How about adding a unit test for the added method?
I think it would be nice to add the normal case and exception cases of the method. This is because it will serve as a document and a safeguard for developers who analyze and modify this method in the future.
@dc7303 Thanks for your comments
Meanwhile, I'm already done. Once review has done, I will send a PR of JS SDK too.
Yes, you are right. I should have done that before. I'm gonna do it. In addition, It would be also great if there were more tests to figure out the intentions for new contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution.
Replace the type of client_id to correspond with the Agent. For more details: yorkie-team/yorkie#145
…ie-team#133) Replace the type of client_id to correspond with the Agent. For more details: yorkie-team/yorkie#145
…ie-team#145) A 24 bytes hex-encoded string can be replaced with 12 bytes of the array to reduce the size of marshaled data using Protobuf.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: