Support for null values #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
==========================================
+ Coverage 57.48% 58.75% +1.26%
==========================================
Files 37 37
Lines 3262 3280 +18
==========================================
+ Hits 1875 1927 +52
+ Misses 1202 1166 -36
- Partials 185 187 +2
Continue to review full report at Codecov.
|
hackerwins
force-pushed
the
null-value
branch
4 times, most recently
from
4ff5d6c
to
39ad65f
Compare
ppeeou
reviewed
Mar 13, 2021
ppeeou
approved these changes
Mar 13, 2021
mojosoeun
approved these changes
Mar 14, 2021
api/converter/converter_test.go
Outdated
| @@ -67,6 +67,7 @@ func TestConverter(t *testing.T) { | |||
| err := doc.Update(func(root *proxy.ObjectProxy) error { | |||
| // an object and primitive types | |||
| root.SetNewObject("k1"). | |||
| SetNull("k.1.0"). | |||
There was a problem hiding this comment.
I'm curious about "k.1.0". 🤔 Is it different with "k1.0"?
There was a problem hiding this comment.
@mojosoeun No. It's just a key. I will change it to the same pattern as the other keys.
Co-authored-by: Hyunwoo.Jo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Support for null values.
Which issue(s) this PR fixes:
Fixes yorkie-team/yorkie-js-sdk#156
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: