Calculate the size of Text in UTF-16 code units #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External editors often don't consider Grapheme Clusters, so we calculate the size of Text in the same way as in JavaScript. For more details: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/split
Codecov Report
@@ Coverage Diff @@
## main #165 +/- ##
==========================================
+ Coverage 59.34% 59.37% +0.02%
==========================================
Files 37 37
Lines 3289 3291 +2
==========================================
+ Hits 1952 1954 +2
Misses 1151 1151
Partials 186 186
Continue to review full report at Codecov.
|
This was referenced Mar 24, 2021
jeonjonghyeok
pushed a commit
to jeonjonghyeok/yorkie
that referenced
this pull request
Aug 4, 2022
External editors often don't consider Grapheme Clusters, so we calculate the size of Text in the same way as in JavaScript. For more details: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/split
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
External editors often don't consider Grapheme Clusters, so we calculate the
size of Text in the same way as in JavaScript.
For more details:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/split
Which issue(s) this PR fixes:
Fixes #110
Special notes for your reviewer:
yorkie-team/yorkie-js-sdk#167 (comment)
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: