jest: ensure Buffer instanceof Uint8Array

jestjs/jest#4422
yoursunny · Sep 24, 2019 · d191172 · d191172
1 parent 19eed49
commit d191172
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 31 deletions.
diff --git a/jest.config.js b/jest.config.js
@@ -2,7 +2,7 @@ const path = require("path");
 
 module.exports = {
   preset: 'ts-jest',
-  testEnvironment: 'node',
+  testEnvironment: './mk/jest-env/node',
 
   moduleFileExtensions: ['ts', 'js'],
   moduleNameMapper: {

diff --git a/mk/jest-env/node.js b/mk/jest-env/node.js
@@ -0,0 +1,10 @@
+const NodeEnvironment = require("jest-environment-node");
+
+class MyEnvironment extends NodeEnvironment {
+  async setup() {
+    await super.setup();
+    this.global.Uint8Array = Uint8Array;
+  }
+}
+
+module.exports = MyEnvironment;
diff --git a/packages/tlv/package.json b/packages/tlv/package.json
@@ -22,11 +22,5 @@
   "publishConfig": {
     "main": "lib/index.js",
     "types": "lib/index.d.ts"
-  },
-  "dependencies": {
-    "is-buffer": "^2.0.3"
-  },
-  "devDependencies": {
-    "@types/is-buffer": "^2.0.0"
   }
 }
diff --git a/packages/tlv/src/decoder.ts b/packages/tlv/src/decoder.ts
@@ -1,5 +1,3 @@
-import isBuffer from "is-buffer";
-
 export interface Decodable<R> {
   decodeFrom(decoder: Decoder): R;
 }
@@ -52,9 +50,6 @@ export class Decoder {
   private offset: number = 0;
 
   constructor(private input: Uint8Array) {
-    if (isBuffer(input)) {
-      this.input = new Uint8Array(input.buffer, input.byteOffset, input.byteLength);
-    }
   }
 
   /** Read TLV structure. */

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml