Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starboard/types.h: Remove kSbInvalidInt #4386

Merged
merged 5 commits into from
Nov 12, 2024
Merged

starboard/types.h: Remove kSbInvalidInt #4386

merged 5 commits into from
Nov 12, 2024

Commits on Nov 11, 2024

  1. starboard/types.h: Remove kSbInvalidInt 

    By inlining the necessary min-int equivalent.

b/366064934
    @yell0wd0g
    yell0wd0g committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    0415f1b View commit details
    Browse the repository at this point in the history

  2. Don't use C++ stuff

    @yell0wd0g
    yell0wd0g committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    6cba140 View commit details
    Browse the repository at this point in the history

  3. Use sites of kSbInvalidInt are C90, so can't use std::numeric_limits<… 

    …> or anything like that, must use INT_MIN
    @yell0wd0g
    yell0wd0g committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    2ba24b3 View commit details
    Browse the repository at this point in the history

  4. Forgot a commented out thing

    @yell0wd0g
    yell0wd0g committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ddbe110 View commit details
    Browse the repository at this point in the history

  5. Remove empty line

    @yell0wd0g
    yell0wd0g committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    6573343 View commit details
    Browse the repository at this point in the history