Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix __aexit__ signatures #323

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix __aexit__ signatures #323

merged 1 commit into from
Oct 31, 2024

Conversation

hxyannay
Copy link
Contributor

@hxyannay hxyannay commented Oct 30, 2024 •
edited
Loading

Notes

Please describe your changes here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

All of these are optional:

  • I have performed a self-review of my own code
  • I have run ./scripts/before_commit.sh to follow the style guidelines of this project
  • I have tested my code changes

Thank you!

@vemel
Copy link
Collaborator

vemel commented Oct 31, 2024 •
edited
Loading

Hello!

Thank you for your contribution. In order to keep static stubs consistent and independent from mypy_boto3_builder releases, they were moved to separate repositiories:

https://github.com/youtype/types-aiobotocore
https://github.com/youtype/types-aioboto3

That would be great if you could create PRs with your changes in these two repos. This way the changes will appear in the next types-aiobotocore/types-aioboto3 releases even if builder is not updated. Also, it allows me to make post-releases if you need the changes ASAP.

Please keep this PR open, I will merge it once two repos above are updated. Otherwise, your changes will be wiped out on the next static stubs pull.

@vemel vemel added the 👋 response needed Awaiting response from a reporter label Oct 31, 2024
@vemel vemel self-requested a review October 31, 2024 10:34
vemel
vemel requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@vemel vemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replicate the changes you made in

https://github.com/youtype/types-aiobotocore
https://github.com/youtype/types-aioboto3

mypy_boto3_builder/stubs_static/types-aioboto3/dynamodb/table.pyi
Comment on lines -37 to +38
exc_type: Optional[Type[Exception]],
exc_value: Optional[Exception],
exc_type: Optional[Type[BaseException]],
exc_value: Optional[BaseException],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be moved to https://github.com/youtype/types-aioboto3/blob/main/aioboto3-stubs/dynamodb/table.pyi

mypy_boto3_builder/stubs_static/types-aioboto3/resources/base.pyi
Comment on lines -15 to +16
exc_type: Optional[Type[Exception]],
exc_value: Optional[Exception],
exc_type: Optional[Type[BaseException]],
exc_value: Optional[BaseException],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be moved to https://github.com/youtype/types-aioboto3/blob/main/aioboto3-stubs/resources/base.pyi

mypy_boto3_builder/stubs_static/types-aioboto3/s3/cse.pyi
Comment on lines -102 to +103
exc_type: Optional[Type[Exception]],
exc_val: Optional[Exception],
exc_type: Optional[Type[BaseException]],
exc_val: Optional[BaseException],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be moved to https://github.com/youtype/types-aioboto3/blob/main/aioboto3-stubs/s3/cse.pyi

mypy_boto3_builder/stubs_static/types-aioboto3/session.pyi
Comment on lines -94 to +95
exc_type: Optional[Type[Exception]],
exc: Optional[Exception],
exc_type: Optional[Type[BaseException]],
exc: Optional[BaseException],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be moved to https://github.com/youtype/types-aioboto3/blob/main/aioboto3-stubs/session.pyi

mypy_boto3_builder/stubs_static/types-aiobotocore/client.pyi
Comment on lines -35 to +36
exc_type: Optional[Type[Exception]],
exc_val: Optional[Exception],
exc_type: Optional[Type[BaseException]],
exc_val: Optional[BaseException],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be moved to https://github.com/youtype/types-aiobotocore/blob/main/aiobotocore-stubs/client.pyi

mypy_boto3_builder/stubs_static/types-aiobotocore/httpsession.pyi
Comment on lines -24 to +25
exc_type: Optional[Type[Exception]],
exc_val: Optional[Exception],
exc_type: Optional[Type[BaseException]],
exc_val: Optional[BaseException],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be moved to https://github.com/youtype/types-aiobotocore/blob/main/aiobotocore-stubs/httpsession.pyi

mypy_boto3_builder/stubs_static/types-aiobotocore/response.pyi
Comment on lines -20 to +21
exc_type: Optional[Type[Exception]],
exc_val: Optional[Exception],
exc_type: Optional[Type[BaseException]],
exc_val: Optional[BaseException],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be moved to https://github.com/youtype/types-aiobotocore/blob/main/aiobotocore-stubs/response.pyi

mypy_boto3_builder/stubs_static/types-aiobotocore/session.pyi
Comment on lines -20 to +21
exc_type: Optional[Type[Exception]],
exc_val: Optional[Exception],
exc_type: Optional[Type[BaseException]],
exc_val: Optional[BaseException],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be moved to https://github.com/youtype/types-aiobotocore/blob/main/aiobotocore-stubs/session.pyi

mypy_boto3_builder/templates/types-aioboto3/aioboto3-stubs/session.pyi.jinja2
Comment on lines -77 to +78
exc_type: Optional[Type[Exception]],
exc: Optional[Exception],
exc_type: Optional[Type[BaseException]],
exc: Optional[BaseException],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mypy_boto3_builder/templates/types-aiobotocore/aiobotocore-stubs/session.pyi.jinja2
Comment on lines -24 to +25
exc_type: Optional[Type[Exception]],
exc_val: Optional[Exception],
exc_type: Optional[Type[BaseException]],
exc_val: Optional[BaseException],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vemel vemel merged commit 192ad65 into youtype:main Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vemel vemel vemel requested changes

Assignees
No one assigned
Labels
👋 response needed Awaiting response from a reporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hxyannay @vemel