Merge branch 'master' of https://github.com/yozik04/nibe

yozik04 · Dec 10, 2023 · 786fb56 · 786fb56
2 parents ce45060 + 74c8beb
commit 786fb56
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/nibe/connection/nibegw.py b/nibe/connection/nibegw.py
@@ -641,6 +641,10 @@ def _encode(self, obj, context, path):
     OPERATIONAL_MODE=0x04,
     FUNCTIONS=0x05,
     TEMPERATURE=0x06,
+    SETPOINT_S1=0x09,
+    SETPOINT_S2=0x11,
+    SETPOINT_S3=0x13,
+    SETPOINT_S4=0x15,
 )
 
 ADDRESS_TO_ROOM_TEMP_COIL = {
@@ -696,6 +700,10 @@ def _encode(self, obj, context, path):
                         allow_cooling=0x04,
                     ),
                     "OPERATIONAL_MODE": Int8ub,
+                    "SETPOINT_S1": FixedPoint(Int8ub, 0.1, 0.0),
+                    "SETPOINT_S2": FixedPoint(Int8ub, 0.1, 0.0),
+                    "SETPOINT_S3": FixedPoint(Int8ub, 0.1, 0.0),
+                    "SETPOINT_S4": FixedPoint(Int8ub, 0.1, 0.0),
                 },
                 default=Select(
                     Int16ul,

diff --git a/tests/connection/test_nibegw_message_parsing.py b/tests/connection/test_nibegw_message_parsing.py
@@ -308,6 +308,12 @@ def test_parse_rmu_write_request(self):
         assert data.data.index == "TEMPERATURE"
         assert data.data.value == 21.0
 
+        hex = bytes([192, 96, 3, 9, 230, 0, 76]).hex()
+        data = self._parse_hexlified_raw_message(hex)
+        assert data.cmd == "RMU_WRITE_REQ"
+        assert data.data.index == "SETPOINT_S1"
+        assert data.data.value == 23.0
+
 
 if __name__ == "__main__":
     unittest.main()